From: Jens Lechtenboerger <lechten@wi.uni-muenster.de>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: pcase failure with Emacs 24 (was Emacs version for Org 9.4?)
Date: Wed, 16 Sep 2020 07:40:22 +0200 [thread overview]
Message-ID: <87y2la9t4p.fsf@wi.uni-muenster.de> (raw)
In-Reply-To: <877dsu75lo.fsf@kyleam.com> (Kyle Meyer's message of "Tue, 15 Sep 2020 23:39:15 -0400")
On 2020-09-15, Kyle Meyer wrote:
> It is pretty tricky to debug, but the failure starts with 4a27b67fd
> (org-element: Fix property drawers parsing, 2020-04-22). As far as I
> can see, the pattern introduced there is perfectly valid and should be
> compatible with Emacs 24. I'd _guess_ this is a pcase bug in Emacs 24,
> particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I
> didn't make an effort to try to understand that commit.
>
> Interestingly, the error goes away if I just swap the elements in the
> pcase (and ...) pattern added by that commit. Dunno, but if that clears
> up the failure on your end as well, I don't see any reason to not make
> that change.
>
>
> diff --git a/lisp/org-element.el b/lisp/org-element.el
> [...]
Yes, that fixes the problem over here.
Many thanks for debugging this, I’m deeply impressed.
Best wishes
Jens
next prev parent reply other threads:[~2020-09-16 5:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 8:22 Emacs version for Org 9.4? Jens Lechtenboerger
2020-09-15 9:46 ` Jeremie Juste
2020-09-15 10:57 ` Jens Lechtenboerger
2020-09-16 3:39 ` pcase failure with Emacs 24 (was Emacs version for Org 9.4?) Kyle Meyer
2020-09-16 5:40 ` Jens Lechtenboerger [this message]
2020-09-17 1:56 ` Kyle Meyer
2020-09-17 15:42 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2la9t4p.fsf@wi.uni-muenster.de \
--to=lechten@wi.uni-muenster.de \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).