From: Kyle Meyer <kyle@kyleam.com>
To: Martin Rottensteiner <martin.rottensteiner.list@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: S-left / S-right with (double) prefix C-u without scheduled time (only date)
Date: Tue, 03 Nov 2020 01:22:38 -0500 [thread overview]
Message-ID: <87y2jjnemp.fsf@kyleam.com> (raw)
In-Reply-To: <CAE3hGsskD004omuoRvV8-gAR2BWkg3-XO4_eFLSTs84qD_1yOA@mail.gmail.com>
Martin Rottensteiner writes:
> In my setup in org 9.4 the behaviour is like this for a scheduled date
> without scheduled time (for example SCHEDULED: <2020-10-27>:
> C-u S-left: Date changes to date before (26th)
> C-u S-right: Date does not change
> C-u C-u S-left: Date changes to date before (26th)
> C-u C-u: S-right: Date does not change
Hmph, that discrepancy between left and right is odd...
Underneath org-timestamp-change is being called with WHAT as hour or
minute. Regardless of whether the timestamp has a time, it's doing
(setq time
(apply #'encode-time
(or (car time0) 0)
(+ (if (eq timestamp? 'minute) n 0) (nth 1 time0))
(+ (if (eq timestamp? 'hour) n 0) (nth 2 time0))
(+ (if (eq timestamp? 'day) n 0) (nth 3 time0))
(+ (if (eq timestamp? 'month) n 0) (nth 4 time0))
(+ (if (eq timestamp? 'year) n 0) (nth 5 time0))
(nthcdr 6 time0)))
So that explains why left shifts the date, as it's essentially starting
from 00:00.
> I would prefer this behaviour instead (my proposal):
> C-u S-left: Add a default time (e.g. 6:00)
> C-u S-right: Add a default time (e.g. 6:00)
> C-u C-u S-left: Add a default time (e.g. 6:00)
> C-u C-u: S-right: Add a default time (e.g. 6:00)
C-u+ is an explicit request to operate on a time part, so that sounds
sensible to me.
> Scheduled date+time Timestamps can afterwards be changed as expected with
> C-u prefix(es).
Yes, and, based on the current design, it should even work without a
prefix for successive calls.
> What I found out until now:
> ( org-schedule nil "12:00" ) adds a time 12:00 to a SCHEDULED date property.
> (if (< (length (org-entry-get nil "SCHEDULED")) 16) (print
> 'scheduled_time_missing) (print 'scheduled_time_existent))
> org-timestamp-has-time-p: could maybe better be used instead for finding
> out if time is not present.
>
> I think this would be a better default behaviour or the current behaviour
> might even be a bug.
I think the current behavior falls into the oversight/bug category,
especially given the left/right discrepancy. Here's a minimal fix that
results in your desired behavior (assuming you don't have a preference
for any particular range of initial times).
diff --git a/lisp/org.el b/lisp/org.el
index 03df139fb..04089c6ec 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14964,7 +14964,8 @@ (defun org-timestamp-change (n &optional what updown suppress-tmp-delay)
(setq extra (match-string 1 ts))
(when suppress-tmp-delay
(setq extra (replace-regexp-in-string " --[0-9]+[hdwmy]" "" extra))))
- (when (string-match "^.\\{10\\}.*?[0-9]+:[0-9][0-9]" ts)
+ (when (or (memq what '(hour minute))
+ (string-match "^.\\{10\\}.*?[0-9]+:[0-9][0-9]" ts))
(setq with-hm t))
(setq time0 (org-parse-time-string ts))
(when (and updown
prev parent reply other threads:[~2020-11-03 6:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 7:16 S-left / S-right with (double) prefix C-u without scheduled time (only date) Martin Rottensteiner
2020-11-03 6:22 ` Kyle Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2jjnemp.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=martin.rottensteiner.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).