From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oMWYLshHW2BgYQAA0tVLHw (envelope-from ) for ; Wed, 24 Mar 2021 14:08:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YKRdKshHW2CcPgAAbx9fmQ (envelope-from ) for ; Wed, 24 Mar 2021 14:08:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6304124659 for ; Wed, 24 Mar 2021 15:08:07 +0100 (CET) Received: from localhost ([::1]:38510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP4B4-0008EM-48 for larch@yhetil.org; Wed, 24 Mar 2021 10:08:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP4Ah-0008EG-4m for emacs-orgmode@gnu.org; Wed, 24 Mar 2021 10:07:43 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:41907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lP4Af-00029B-4O for emacs-orgmode@gnu.org; Wed, 24 Mar 2021 10:07:42 -0400 Received: by mail-lf1-x136.google.com with SMTP id b14so18914137lfv.8 for ; Wed, 24 Mar 2021 07:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=25RDQLGd7CImy1+tON3OQ9rdCnkUvpJuxqwP4mlsTiY=; b=XZBxQKGutn7BXHwDfCBBDRXexunEWSh3s6y3rdxC1mRAxh8/KnVs2NHdBLqIIbO7+t fY41Lnosp3cwmE5hp3e13zD4fYw7C4dPgjREOHlmR6Eoxd03DPtmq5FMnMj0M4HeGTBl CPht8H39c4G97JZIdMOOT9ix2vp+T3W3yRXkMh2vzPAb/38qpc81jI2DTTI0jZOBJQ8y BGzuKVm/wK+Nbp8y7LjgH56LBCyMxBSRaU6XKXc3cfnJ/Qb0qu1qYlKBtBjUawvgWWLN ocS7BlEQW+G+uffYo/Zr77FFziVSW+Sw/yxMn9dwzAxvgrDoqztayh1sNrXQp17A3sr3 Uj9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=25RDQLGd7CImy1+tON3OQ9rdCnkUvpJuxqwP4mlsTiY=; b=Br516jNJXT81uKbGMF+fe7brw9ST2ccgsEawToMlVi7oWZ8D2k48CX+vwhb9b6umGN 1SrIMQ77CBFJyfdmfOgEg8Kyi5o23xArmiKdvG8iE9k87PwgOZ5yZX4lRFstD3PrkfEs P7gyzsprQJ2hi7MRsiITQkFjKvo9T6OPkQf/2KL7Jz+jJcR+OXYh0rxFnlyIFj/FrvDs aoW32JlpHWVzV6bn6Q86ahibkuEa41/M3nvBCZyAkBj+BgTraBXqkFt1GCuH7X8lMAlU eysVMuuI362KqhJxvUg3100bYf74t0cMK9bJzELLMAnq2NKnjvgIrn+rhJDLG4j1gwPt DqSA== X-Gm-Message-State: AOAM5303YWGbWAV/J0VYa7qZOxJlpfgAniJG8s3dJxONQzfWCtfmDcjP 41iN2oz5mRu3DaiQYMYpnNU= X-Google-Smtp-Source: ABdhPJwnpCVWplZjzR0rkgae2llCSRcMj68EkKBESv5WiQJ2pt7fR9XB7IzoZmd/mwxOUf76tCDTAg== X-Received: by 2002:a19:5d8:: with SMTP id 207mr2085856lff.232.1616594858952; Wed, 24 Mar 2021 07:07:38 -0700 (PDT) Received: from localhost ([158.255.2.14]) by smtp.gmail.com with ESMTPSA id f8sm325908ljn.1.2021.03.24.07.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 07:07:38 -0700 (PDT) From: Ihor Radchenko To: Maxim Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] Re: Bug: Plain https links with brackets are not recognised [9.4.4 (release_9.4.4-625-g763c7a @ /home/yantar92/.emacs.d/straight/build/org/)] In-Reply-To: References: <87pn03g3rr.fsf@localhost> <87sg4zu47p.fsf@kyleam.com> <87k0qbk4rq.fsf@localhost> <87h7lfk4mz.fsf@localhost> <8735wvuvi3.fsf@localhost> <87czvv5gil.fsf@localhost> Date: Wed, 24 Mar 2021 22:11:38 +0800 Message-ID: <87y2ec4p5x.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=yantar92@gmail.com; helo=mail-lf1-x136.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616594888; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=25RDQLGd7CImy1+tON3OQ9rdCnkUvpJuxqwP4mlsTiY=; b=OSb7h/FD2N2jRp19K+i3Am6c2Uu+uP4iyIO/j8RT2kM2+f/2WNILw5XLhSidZPF9YOJeXQ soqbl+mrzG992Tk07+1E46U8PU/G/1uDa8ioHMQ3tfUNzSKUUeFKyKbduQZmlbYl2z6bpm 75m/7xsRrth7+2sgIBggpZ86/NTK5M1cSEixdXpSDPxPe1Iz6KMC6ec8FODJeZ2STbp+8A uD/gNjwcQwvi+1l1O5EMnwtiTErbhiyUkp5W5zFI2+GNkpPVJzBGLp5J2U5kpQobQ8ANs2 Gf4IHUN79ys0eLIE1XrdAMVDcUkLX7K6LrBNegYIhatsR4si8Yj1yL4ibnyuyw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616594888; a=rsa-sha256; cv=none; b=NoVw9rFX5/fqn7aibfeYg1NOagZIW7TvO6qyktCdNHyHAqcnaFFNoiKnvMEMubgM7NHeFf uWsOQix+N8WJd1ZBrEDmHsX9faaHHJF40dSl4PuRwqFvDv1UIXEknbLNjoHoV34ZtGcS4s gcL0xeELfuD/v7cof01heL9vrWM87xx1xq0oDHgogavTtFBUvXx2q09s1HxWVVUvAN5MJh ts+G6Rw5eEzH5z3J5t1Pm2eHcaSOdWhJEnJCU1gzEotlVmv/cC63vrulZAK7Md7zf6t8dF dAZQMIhBZPGWezA4rmJ0Q4H5ZYvu7lafJ5BLmp4TTZ+BKvD+rb49ZzGJfxJy8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=XZBxQKGu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.17 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=XZBxQKGu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 6304124659 X-Spam-Score: -3.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: mESi03w4qNMK Maxim Nikulin writes: > Example for #+STARTUP: overview: > > org-activate-links 560 0.028971085 5.173...e-05 > > For content number of calls is 410, without special settings (all) 120, > let me remind that it is for 10 find-file invocations. Another example > > org-activate-links 410 0.1384633219 0.0003377154 I repeated your benchmark on my largest working file (~14k links): ;; with patch ;; org-activate-links 400 0.0259791009 6.494...e-05 ;; org-activate-links 400 0.0114822140 2.870...e-05 ;; org-activate-links 400 0.0255080609 6.377...e-05 ;; without patch ;; org-activate-links 400 0.0297167870 7.429...e-05 ;; org-activate-links 400 0.0149334709 3.733...e-05 ;; org-activate-links 400 0.0105385180 2.634...e-05 There is not much difference indeed. I guess, there was something about my config and external packages. > I see such variations in both cases with and without the patch, but > these numbers are negligible in my opinion. Your benchmark is measuring is jit-lock - there will be no reliable result as jit-lock is timer-based. I did more reliable version as well: (progn (require 'elp) (require 'org-element) (setq elp-function-list (list #'org-activate-links)) (elp-instrument-list nil) (dolist (i (number-sequence 1 10)) (message "iter %d" i) (find-file "~/Org/notes.org") (font-lock-ensure) ;; Force fontification in all the buffer (sit-for 1) (kill-buffer "notes.org") (sit-for 1)) (elp-results)) Results are not different though (time-per-single-call): ;; with patch + font-lock-ensure ;; org-activate-links 163290 9.720667509 5.953...e-05 ;; org-activate-links 163290 9.8090518640 6.007...e-05 ;; without patch + font-lock-ensure ;; org-activate-links 163290 9.9175657860 6.073...e-05 ;; org-activate-links 163290 10.073281878 6.168...e-05 This latter case was what was happening with my config. Some package was causing full buffer fontification. > In my opinion, combining changes related to white spaces and meaningful > modifications makes commits less clear, especially when reading email. > However the following recommendation has certainly more weight: > > https://orgmode.org/list/87zh2hosex.fsf@bzg.fr/ From: Bastien >> Also, the convention in Emacs is to avoid whitespaces-only commits, >> you need to fix whitespaces within other non-whitespaces changes in >> a commit. Actually, I feel confused now. I remember that message from Bastien, but now I cannot recall what is considered "fix whitespaces". Do we use tab-convention or space-convention? I think I will better clear the whitespace staff in the patch before I understand the whitespace policy more clearly. At least, the patch will be more readable. Best, Ihor