From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4loyF74DiGBEXgAAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 14:29:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CPMLEr4DiGD8QgAA1q6Kng (envelope-from ) for ; Tue, 27 Apr 2021 12:29:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 21BC4270CE for ; Tue, 27 Apr 2021 14:29:50 +0200 (CEST) Received: from localhost ([::1]:44922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbMqb-0007Rm-6I for larch@yhetil.org; Tue, 27 Apr 2021 08:29:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbMpi-0007C6-NZ for emacs-orgmode@gnu.org; Tue, 27 Apr 2021 08:28:54 -0400 Received: from mail-qv1-xf2b.google.com ([2607:f8b0:4864:20::f2b]:45584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbMph-0000aK-5L; Tue, 27 Apr 2021 08:28:54 -0400 Received: by mail-qv1-xf2b.google.com with SMTP id a30so2108909qvb.12; Tue, 27 Apr 2021 05:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=/0aoKGTLMC0ZjmvYnNgz8mHov+KMjiM3+r759tPAOGA=; b=U3qyvXaFs6ZWwzc4ktQEmqaCQqlhAeSSoMghy0Evw4XUjFM5sL/2CUUqmmEnq1aS6m qB62jIC+cD/3PDP81RDy/f8e01LrqDN3ge7TM3W3qQE5+plJzDT2eK3Gf961gNJ8nIK3 0av9qW+rP9l2zBebo+hQcL4Hzxgk0e8OhN7ZxhfKUiIZ/AwHtxADdi+s5Zi41PDq0rHv wz/g6gj8p1kn09KDp66D3H8VNtUNGhPHNEs6vpCH+dHdtDmJdZJYV284ciNqIJAlx9cJ 1V/9x0IOmXUbS4DaaMrVFNvJfbR1KYEWEcVj3TBu2Y7GYMr2yhIgH7B0X/D5ltYFoEVD xt0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=/0aoKGTLMC0ZjmvYnNgz8mHov+KMjiM3+r759tPAOGA=; b=YwdUiRUfKr2VDPkD4Apdvs7qkg4RoDKBOAXJbX9WOxy1JDfOATWlhHZEEOR8nUAOFR iA/UTDKOIgnf+9DrgUW5uOwstS06DyTU+vmzhUib7twQxX/pYhW5FqJDHJgxsdvit0li HuDj7bUuFViFH/HfnLihE221Md7qooO8fAa7Iykj01/QTHs6qgDr+F+7Wc60ZD/oPN8w 5oSAzi+x5/yuzmsVDtyWgu064eQq2epnjN99lvgDQcE17k+4k9+LR/QiRo+NbR2e+PYm gD7/ATwlbC4/f01fD6kYc2oYtRkZ8pycxN1Iu4oJkbVberypI1qYsfgmdLReqYlDaWi3 SyKg== X-Gm-Message-State: AOAM531h7hbq6yOIOd+C1kYTFQ++HL2Q+1ksX0WPwogAhzW8yAoUp68j xUFJrzQYS9voa2FByHz9JUCyCj4s0GQ= X-Google-Smtp-Source: ABdhPJzOyR4WQUsjLODKK2V3oCnNb/qh+9wzJ6COOSWHvFyD9WerTTq+oCudS6af/L+SriZ9B2r6nw== X-Received: by 2002:ad4:5be4:: with SMTP id k4mr23192247qvc.53.1619526529703; Tue, 27 Apr 2021 05:28:49 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id d2sm14746659qtg.85.2021.04.27.05.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 05:28:48 -0700 (PDT) References: <87y2d5mde2.fsf@gmail.com> <87a6plus2v.fsf@gnu.org> <87wnsofynx.fsf@kyleam.com> User-agent: mu4e 1.5.11; emacs 28.0.50 From: No Wayman To: Kyle Meyer Subject: Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)] Date: Tue, 27 Apr 2021 08:28:36 -0400 In-reply-to: <87wnsofynx.fsf@kyleam.com> Message-ID: <87y2d3oqrk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::f2b; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qv1-xf2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 21BC4270CE X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: ip9AA/KOave8 Kyle Meyer writes: > Bastien writes: > >> Hi, >> >> thanks for the patch, we do indeed need to move forward for >> this. >> >> Could you propose the patch against the master branch (not the >> maint >> branch, since this is not a bugfix) and perhaps fix *all* >> warnings? > > Thanks, but these were already taken care of by 8c29cbdef > (Backport > commit c45bfd3c4 from Emacs, 2021-04-18), which was merged into > master > with 664b65344. Apologies for the noise!