From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kTR8I5+Z4GB0yAAAgWs5BA (envelope-from ) for ; Sat, 03 Jul 2021 19:08:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QMKTHp+Z4GBMUQAA1q6Kng (envelope-from ) for ; Sat, 03 Jul 2021 17:08:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D6BF71DEEC for ; Sat, 3 Jul 2021 19:08:46 +0200 (CEST) Received: from localhost ([::1]:37188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzj8G-00066Q-Ul for larch@yhetil.org; Sat, 03 Jul 2021 13:08:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzj7s-00066G-Hu for emacs-orgmode@gnu.org; Sat, 03 Jul 2021 13:08:20 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:44552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzj7p-0008J2-QD for emacs-orgmode@gnu.org; Sat, 03 Jul 2021 13:08:20 -0400 Received: by mail-wr1-x42d.google.com with SMTP id t15so13126385wry.11 for ; Sat, 03 Jul 2021 10:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IRlLQxtwr9dwqzD2YIEDpoIm1s+52ROdc+QZieoqvf0=; b=emRnQy2jfk/T4cVqyE39JlgkmbYSxr5ULMo1vpMlqFhVUnYyuG/yzF9gHLWC1cfmoW wsb6NLygqb3OJyq+yEAiZSIX/Xe+gZirheHQMYKmFLyGCZBR/GVakMKNgCQMGbQJu6I+ VD9yNFAgSJ2jF6FBwYRcd8cp1RluMdA6AqjLH7UsUY4Z3ickPC6lF2O9BZFj+QjYZC0Z US0c6Vcd0TPSPKW0SiHfAEQ1AOzgB3SVgs6FGi0MyFoUxdGfehAYUM5Zy30DVkdfnE/q YdhgqjWKDa8f16awe8EheZMQsr6kHzSLk1NclDGOoQYt/jOD3UFYruXl29X8SlIwLto4 Mnqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IRlLQxtwr9dwqzD2YIEDpoIm1s+52ROdc+QZieoqvf0=; b=fkAecBeXvD2u2dkcVhvxLJChQ6cIdZr4sZHfnVasQngsLzOjTeLOGhG/b02uT+UaS+ oDDqBpcXf1/y2jvHgAqvvzLPAJL6WmMfB+R/kaVlTBbUuEHvz+C1H/1XpzIqFAFv5iP9 ApNgRdBrvoM1KRnxGBld2O6QfA6anMMZMt6j3+gjCFWj5p9BWJsBcESbEWYUG37QbbZp RG+lJ2Dc2Whlj5DJwaptyBrElzunCRliO0ikdb2J+UcxlEdnWqqY/Ycq8XfGilaW8gOz gVReclzDCxA9EXfpuYAyIeV5lppqBIYd2UbfO0PR+z0uGXHVaDaiVCIcE+HnQRim5/Iv 8B7w== X-Gm-Message-State: AOAM531T7+BZfktEaTd481RyrcFyZdLrR02WbZ8IjpQexuDjoGkqHgKQ nfmWKhy1QJHLBkSIC7sHWi4= X-Google-Smtp-Source: ABdhPJzH1oPCkQSTX5IfxhcJyBhN2YkC9Fn6E2eSsrkMllwBl6esce2PQtqAj56bPhTP/o3zuZ28kQ== X-Received: by 2002:adf:cd86:: with SMTP id q6mr5855749wrj.422.1625332095621; Sat, 03 Jul 2021 10:08:15 -0700 (PDT) Received: from freegnu (82-64-129-7.subs.proxad.net. [82.64.129.7]) by smtp.gmail.com with ESMTPSA id l9sm7198784wrp.14.2021.07.03.10.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 10:08:15 -0700 (PDT) From: Jeremie Juste To: Jack Kamm Subject: Re: [PATCH] ob-R output file with graphics parameter References: <8735t8nqlf.fsf@gmail.com> <87pmwbty75.fsf@yandex.com> <871r8n1ban.fsf@gmail.com> <87o8bpbqp3.fsf@gmail.com> <87h7hcowmv.fsf@gmail.com> Date: Sat, 03 Jul 2021 19:08:14 +0200 In-Reply-To: <87h7hcowmv.fsf@gmail.com> (Jack Kamm's message of "Fri, 02 Jul 2021 21:21:28 -0700") Message-ID: <87y2anwcjl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=jeremiejuste@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Baxter , Org Mode , Timothy Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625332127; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IRlLQxtwr9dwqzD2YIEDpoIm1s+52ROdc+QZieoqvf0=; b=EJSAFhl24DncnxM47mYkElJQgaSXTMs2O68VETM9p1+4SUdhuTrQ1Cqvh+0956peJXlll3 KhnRRl339kqAkThMkzWfL5SA2pkYP6l7JuF9zfULdD+ZXO0rBzFYQYQikoGi5vi9zKtq4u Az0goUcviMbzbTikLhxHFImUl1UOyjKwCydwnnNLaBMs8GxlrWlA6H5IiLYoDikUtbxmEM YWiq+J7ux06pQQBgpurGbnX1yL5mtnX2Y1mmctDRcLHQzpHS2jHOYkhL5Bv4K1smt6sURO QkMgwQN1OkhUhUKyY+cZX9zMInCfSgMJueeEMFKhPKTwxwOJSh9Jh3czR2RcpA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625332127; a=rsa-sha256; cv=none; b=b1qKyFJLpHyr9KKHrd7GPq8RdW09WO6Yk2UmEJvRzufqgvfLeSDZluI3msESwyfvXsIEzz yeJafvlCGAD6ik73WbOoR+242nNO8+jiPhet0K+XtdzdcHyXVmQKIQ4UCuaI0PUiON1uRr bZV/0Jxl4J2NDYqZ4c1W4wWRJ+jhnyR8JotOzzwISaxuKkdGs5PcyU7BYSN0afmuXzbf4a zDrRzbwtkyv7+Zz1M3+O6Zj/nZSmwhMgfSoTbqDerH25XSR1T6DUPlNcurUT8BNLXjystj r1y2ihJ3KF9nCkAyC/Za6M6WtMbiHhDDC7kHOrd7fy6hsEpwy/+clIomWW9FWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=emRnQy2j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=emRnQy2j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D6BF71DEEC X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: vjkuxjNLdiO6 Hello Jack, Many thanks for the feed back On Friday, 2 Jul 2021 at 21:21, Jack Kamm wrote: > Hi Jeremie, > >>> The requirement for a second file parameter was added in Org 9.3 to >>> support the use case in this thread: >>> >>> https://orgmode.org/list/3ac2f42a-8ff2-1464-fa36-451e2ef0eacd@pressure.to/ >>> >>> But this syntax is annoyingly verbose for ob-R users, and also broke >>> lots of ob-R examples prior to Org 9.3. >>> >>> A simple fix might be to have the "graphics" flag implicitly add the >>> "file" flag as well. But we would need to first check that this doesn't >>> break other use cases. >> >> I do agree with this solution. If the current specification works, we >> could make it easy for ob-R user by implicitly adding a file flag. But >> as far as I understand, the change will have to be made in ob-core.el. > > Hmm, I think you're right -- this would have to be done in ob-core.el. >From what I understand, the document has grown in complexity and it is a bit complicated to generate graphics. I unfortunately cannot measure fully the impact of the change other client of the :graphics, :file parameters. I see that the source of the difficulty is that ob-core is handling too much. I remember a time where we had only output, graphics, value, and raw, for the output, and the we file-ext came, this was still fine, the second file parameter might be telling that we are over heating ob-core.el and it will become difficult for it to satisfy all its clients at some point. A way out of this might be for ob-core to delegate more to the respective ob-*.el. It will be duplicated work in some cases but each maintainer would find it easier to add and remove stuffs without having to consider the effect of the change on other ob-*.el. Regarding ob-R.el most of the job was done there already, in fact with the second :file parameter, I believe that the file handling was removed from ob-R.el. So what can ob-core delegate more to it's clients? Regarding the documentation, it might be good that we have a small case for each ob-*.el. When a user is looking how to produce graph with python or R, asymptote or shell might not be very telling for them and the :graphics parameter has a src shell as an example. This might be a killer for the new user. #+begin_src shell :results file link :file "download.tar.gz" wget -c "http://example.com/download.tar.gz" #+end_src Please don't see my comments as criticism. I'm short of time and I share responsibility if anything. I'll try to improve this part. > > I think it would still make sense though, and would be beneficial beyond > ob-R. According to [1], the "graphics" and "link" arguments don't do > anything unless used with "file", so it would make sense for them to > automatically add the "file" argument. I do agree with you again. > > [1] https://orgmode.org/manual/Results-of-Evaluation.html#Results-of-Evaluation > Best regards, -- Jeremie Juste