From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IPx1O4kulmFDNAEAgWs5BA (envelope-from ) for ; Thu, 18 Nov 2021 11:44:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +CsYN4kulmFJRgAAB5/wlQ (envelope-from ) for ; Thu, 18 Nov 2021 10:44:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A30313F3DE for ; Thu, 18 Nov 2021 11:44:25 +0100 (CET) Received: from localhost ([::1]:33368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mneu0-0006Em-1c for larch@yhetil.org; Thu, 18 Nov 2021 05:44:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnetS-0006Bw-EV for emacs-orgmode@gnu.org; Thu, 18 Nov 2021 05:43:50 -0500 Received: from [2607:f8b0:4864:20::631] (port=34326 helo=mail-pl1-x631.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnetR-0006fE-1y for emacs-orgmode@gnu.org; Thu, 18 Nov 2021 05:43:50 -0500 Received: by mail-pl1-x631.google.com with SMTP id y8so4896198plg.1 for ; Thu, 18 Nov 2021 02:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=NjtCKr37owZM2Vhu+qPFuBNqwi5jh+KTGb2PMqOeTPg=; b=HYb5nxYshw+BNDfUXVCPRB5oVyYBJl2ANIW4mfD3X4EeDh1OvXO2zhX9klRGd8KqRu KtWwQcJc7bDKPdkOJ9gMKOV8ueWlP3Dq45zPTZr2LERQ/JrFCoQPIIHARthNFRVyaaMp /szKY/ivO+ZpCJNsc240exf0/mtFvQfCuGgZAOkf4Ofe0AJQKEsTI6+wzIBYaQNK5PBv iKtt6WsIgOlMlfMeCHwLQThqT/V6y0OrXfnifyN3haScImwO//vc13Y0zU6sKMu2QJSs IWkSVgxwnnPoZRAgdvpOe9wE/mhYsltNaFfYLD/Ql7bYlsvzp7J8AvLKoq3iCCp+Pp3s bkxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=NjtCKr37owZM2Vhu+qPFuBNqwi5jh+KTGb2PMqOeTPg=; b=hEjtA4MciwnFJBwMyDQ4duy/SqpD1L9QDr6IbM26+G7uxmzoCL/DzfM/hPbv9pfdzl u1AZkzgua6abIbWwjKBwsO+GbBb1hGgfzUJ/6RIhK3zPUUz/k6mgyA+7ufEcmVewylHn lmH4Etm4JT2ckFXGVfUfpXkK3JXsCXgRv6OAV41qgeI/vamZ2HToa9w8mQZbeg2kS/oU AUD6P2O5lBsdOUrs13FjnY+rmZluCRraMtMd9CVxvfHTRgQ7ipnrSJQDwCcfo1cMk+Q/ TQZLWTTA7yagI6xmCS2Q9ZTQl89AkmD2Xtnu7KqhBP+Z/hbC+NsdMjTcbXErPocm2CpW KIKg== X-Gm-Message-State: AOAM53325b5E5nMScqCYQ9497vbTgw+5W/KgDPJL4f2xxUYpcfXwEKSo TRbiXA1iqx/t0ocLpdqqKbHjJJpv2N8= X-Google-Smtp-Source: ABdhPJwTZy3z0dTx4ZO9STkuBD6ULzDQI/Hn9WZzTfAoeIjABrNbA1fBtzio7UGsYl7gr0STuXTYog== X-Received: by 2002:a17:902:aa43:b0:142:6919:73da with SMTP id c3-20020a170902aa4300b00142691973damr65277078plr.39.1637232221019; Thu, 18 Nov 2021 02:43:41 -0800 (PST) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id f21sm3267636pfc.191.2021.11.18.02.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 02:43:40 -0800 (PST) References: <877derdrnx.fsf@debian-BULLSEYE-live-builder-AMD64> User-agent: mu4e 1.6.9; emacs 28.0.50 From: Timothy To: Jeremie Juste Subject: Re: [PATCH] ob-R async evaluation Date: Thu, 18 Nov 2021 18:36:23 +0800 In-reply-to: <877derdrnx.fsf@debian-BULLSEYE-live-builder-AMD64> X-Woof-Patch: applied Message-ID: <87y25leobq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::631 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637232265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=NjtCKr37owZM2Vhu+qPFuBNqwi5jh+KTGb2PMqOeTPg=; b=Q3/z5yhvLbwX41f3SGkKQWMtJj8n/+D5y+V9kai93Val33+ue1cz4yG9nkZiHZRdaPbuo8 bvusjEf5jY6UKeyy59DxiXyinqRb25l3YJF5mlulc/VOR1iK24emzU8GX0HvOyj0h7HTlI yAbjYGtJRhFRNPCohNoOvIbpzTM6kOcDiwfB7FMPB0XLkZbzd7IYitixYrw8xAGmst2NKf xp/l0hINIkDJKhsgA/6djHSUowiJMezrJ3Lr8kzGTD0QML4I0P9CW5lhuMrKUUciQCI5ui Z87a85JH8BBZfhIppRQ/dRB4zwzxaVBP96vqCpES69YZsZ/vATOR7HvRFTaNjw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637232265; a=rsa-sha256; cv=none; b=SBp6BQhQ3ZV5HATBjGW/tVTKOV+RZdCCRRzC+PLgBRxtDhGCtgSPxHo5c1MjFFh442NGWE oO6QN0bqk9L6OmVmlfcHcMHt4Zv9Grh6mWT1lmqSMkhPeB+W+YOKR0t+6w9y5wdASvt06V wfBzKRVR6wg/WB2w8WuuMODHCaoJDER03Q0Jk+Qy3g42RASEPEz25fOkfVe4ivWzrygU8G 8lZhrrNa/loKtvY9h7+rTkJQseel86y0Y0VfiXRy0gWLzIljSfq1BmhVjSnyO7aMTfov7e +el54RSYaDMGy6pkIfT4ifQdPLUqtqDT8iAjcFNmn+tCfNeBM2fIVVmvRWCQdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HYb5nxYs; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.56 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HYb5nxYs; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A30313F3DE X-Spam-Score: -3.56 X-Migadu-Scanner: scn0.migadu.com X-TUID: tuXlllBIXJwE Hi Jeremie, Sorry it's taken a while to get to this. I've just gone through your patch and it looks quite reasonable. I also took the liberty of fixing the indentation in a few spots and tweaking your commit message. This has just been pushed as 58db28d. > I'm attaching a patch that clean up a bit of non conventional coding > practices (mainly because of my ignorance), in ob-R. These were > initially generating warning during the compilation of org-mode. By the way, just letting you know that your mail client declared your .patch to be a PDF file =F0=9F=98=9B. > [2. application/pdf; 0001-ob-R.el-Patch-4-async-evaluation.patch]... -- Timothy