From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SNDxLLziD2IqnwAAgWs5BA (envelope-from ) for ; Fri, 18 Feb 2022 19:17:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eClcKrziD2IROgEA9RJhRA (envelope-from ) for ; Fri, 18 Feb 2022 19:17:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1400937F16 for ; Fri, 18 Feb 2022 19:17:32 +0100 (CET) Received: from localhost ([::1]:39656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nL7ox-0001mE-7v for larch@yhetil.org; Fri, 18 Feb 2022 13:17:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nL7oP-0001m2-If for emacs-orgmode@gnu.org; Fri, 18 Feb 2022 13:16:57 -0500 Received: from [2001:4b98:dc4:8::231] (port=49665 helo=relay11.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nL7oM-00044X-RY for emacs-orgmode@gnu.org; Fri, 18 Feb 2022 13:16:57 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id ADE07100005; Fri, 18 Feb 2022 18:16:50 +0000 (UTC) From: Nicolas Goaziou To: Kaushal Modi Subject: Re: [PATCH] c-csl : accept relative CSL filenames References: <87h7bgstmz.fsf@nicolasgoaziou.fr> Mail-Followup-To: Kaushal Modi , Emmanuel Charpentier , post+orgmodeml@guelker.eu, emacs-org list Date: Fri, 18 Feb 2022 19:16:49 +0100 In-Reply-To: (Kaushal Modi's message of "Fri, 18 Feb 2022 09:51:32 -0500") Message-ID: <87y2283ur2.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::231 (failed) Received-SPF: pass client-ip=2001:4b98:dc4:8::231; envelope-from=mail@nicolasgoaziou.fr; helo=relay11.mail.gandi.net X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: post+orgmodeml@guelker.eu, Emmanuel Charpentier , emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645208252; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=fHTwlj86MZ3DEPbU+fMJSsvvfvTsyh93mbzTbtVlQ3o=; b=Ixk7Sev1dAYwRF5L8w0KTkHV9wdqBhFIEuHMgv4y999P0lUrPzufNbXa6UcVEbn754ZULn TEDOyLg7yPf+LtDt5/tMU4YQsxNZtfwNFYuBEnTmhL7eo8tjLs4d0tbwz7mDGiSUrYyQUD /rNbClBtBoRdQNip/k+WbpMDe/+iE4ISLPJiBvNR0++qVijD8heCKS8a8NYwefIRsu0jxn 18/OcSZhRThXx1hyeZgoHwpGagTZpvrGmkKiMOJJM7R/osagZa9jYA7tlP3pBnh8GADl/z 7AzCJOhoHZeo6hOe9VYDbxAWUxzk3s45Ur/+WGG3DCDZ5dSc60pEcMHbMvKKDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645208252; a=rsa-sha256; cv=none; b=Hs818MYPLDY0Z84bsHRRzVRQxBsiHEHBiol3e8Xi52Nx24npX8kQgagLrWs+PK6VRP6Ey/ do1i7XdInv7k2cUv9jEyu5ZmcdiCBJPbMLYUDf2zGsifVAKMwZZGdMKar03D5yr3kFlFvg 39zr8+J1TMLihHbAywhdZkqfLShrwm2ZnF86PsSCKhwGnHZddqtw3Cmbyj2/Y9mxsuc20L 66kL6S5OiKnneb62+c32KDBHQQQeJ5IQMwgiw1aG7s2ou8VSBCuDZT83JRlGY6/igeqQGs MlKmvBvZY2Yi5UVbYLZzORuPK/5IZY3PwM/9dpLBILlimA6AcUzwgjKudpxttw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1400937F16 X-Spam-Score: -2.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4gzKbiq6NCsH Hello, Kaushal Modi writes: > Can this commit[1] be merged into the main branch. It is already in the main branch, AFAIU. I assume you mean it should be back-ported to bugfix branch. If that's the case, I don't know. This is a new feature, and not a critical one: there are workarounds, as you found out. This should be available when Org 9.6 is released. I don't know when that will happen. > I believe the behavior I see with this commit on main branch is kind > of obvious and it should prevent this surprise failure for other users > too. It's obvious, but, as a new feature, it was pushed to main instead of bugfix. Note that the error message is explicit anyway. I'm not strictly opposed to back-porting it to bugfix, but is there a compelling reason to break our workflow in this case? > This works for both main and bugfix, but while doing this, I realized > that even string values are not considered safe for this variable. > > Looking through git revisions, I found > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41e67cff0d3bf27ffb57f9a230598b0385341517. n> > Earlier `:safe t' was added for `org-cite-csl-styles-dir'. Instead can > we have `:safe #'string-or-null-p' as suggested by Glenn Morris in > that commit? I don't think Glenn Morris suggests using #'string-or-null-p, which would contradict his statement. He is pointing out that ":safe #'string-or-null-p" is better than ":safe t", even though but allowing arbitrary locations (strings in this case) is not safe anyway. Regards, -- Nicolas Goaziou