From: Ihor Radchenko <yantar92@gmail.com>
To: "Juan Manuel Macías" <maciaschain@posteo.net>
Cc: orgmode <emacs-orgmode@gnu.org>
Subject: Re: [Patch] ob-tangle.el: New value 'ascii' for the header argument ':comments'
Date: Tue, 14 Jun 2022 11:58:30 +0800 [thread overview]
Message-ID: <87y1xzq4k9.fsf@localhost> (raw)
In-Reply-To: <87wndna1lp.fsf@posteo.net>
Juan Manuel Macías <maciaschain@posteo.net> writes:
> My first approach was actually to define some options for
> org-babel-process-comment. But I noticed that a header with properties,
> for example:
> ...
>
> I think the culprit is the '(match-end 0)' in
> org-babel-tangle-single-block:
>
> ...
> (org-back-to-heading t) ; Sets match data
> (match-end 0)) ;; <=========
> (error (point-min)))
I think that the existing code can be improved. Relying on the
undocumented behavior of (org-back-to-heading) is not ideal. Not to
mention code blocks before first headline.
It would be great if you rewrite the existing code to suite both the
defaults and the proposed behavior.
Best,
Ihor
next prev parent reply other threads:[~2022-06-14 3:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 18:28 [Patch] ob-tangle.el: New value 'ascii' for the header argument ':comments' Juan Manuel Macías
2022-06-11 5:39 ` Ihor Radchenko
2022-06-11 11:20 ` Juan Manuel Macías
2022-06-14 3:58 ` Ihor Radchenko [this message]
2022-06-14 11:11 ` Juan Manuel Macías
2022-06-14 11:55 ` Ihor Radchenko
2022-06-15 10:30 ` Juan Manuel Macías
2022-07-21 13:44 ` Juan Manuel Macías
2022-07-25 13:34 ` Ihor Radchenko
2022-07-25 17:13 ` Juan Manuel Macías
2022-07-26 5:35 ` Ihor Radchenko
2022-06-12 19:18 ` Rudolf Adamkovič
2022-06-12 19:55 ` Juan Manuel Macías
2022-06-13 8:24 ` Rudolf Adamkovič
2022-06-13 10:22 ` Juan Manuel Macías
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1xzq4k9.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=maciaschain@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).