From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UNeiHEkc+2JXAQAAbAwnHQ (envelope-from ) for ; Tue, 16 Aug 2022 06:25:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gALfG0kc+2KaYgEAG6o9tA (envelope-from ) for ; Tue, 16 Aug 2022 06:25:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0067B6EBC for ; Tue, 16 Aug 2022 06:25:45 +0200 (CEST) Received: from localhost ([::1]:41882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNo9A-0001QZ-4m for larch@yhetil.org; Tue, 16 Aug 2022 00:25:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNo8d-0001Pn-Nc for emacs-orgmode@gnu.org; Tue, 16 Aug 2022 00:25:12 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:35375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNo8b-0002TL-Ky for emacs-orgmode@gnu.org; Tue, 16 Aug 2022 00:25:11 -0400 Received: by mail-pl1-x631.google.com with SMTP id t3so281243ply.2 for ; Mon, 15 Aug 2022 21:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc; bh=ko39QgsMJHx85juJjG/HRSeGrKb8I9LPRutFcqLHTf4=; b=Pj/R8AdwJdCUO3KSon1bxT8F0o/3X9Yy7v9W9Bzyruv1uSnoPRbIX+w/ouPNp84ZWU 4J5FRWL/2aU65odGSLiISfntIgddMqCpAGdosKrl/3Bwre+Q8j3TuDhKBk9WRB31fa5/ puApRMNcvmdYBh8/MKIJmhMU3Lx6Jf1YRYGEfvX4p3KZ0745BlzChRlpOx5f7mUyLCvz 0FOPYeI2wM0ZstxwPdkAmSeFMlElfW6c2T8+Pri2EhdpJD4kvQKYFkinnoBfweME2jks bo+flddpoWlMBZVRPyHDP+lELS+aOwi8AfYkZtMps/kpHN15xUFHUCDXOYVRWy7fM8O0 U9bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=ko39QgsMJHx85juJjG/HRSeGrKb8I9LPRutFcqLHTf4=; b=krxIGusTiQLaXMnrY8BsdPmZ8LEW7TJ3YYVMVwveU8qrjUC39s9pcgprtuHavnH56D FLOgsLneSLxawRWNPB+BeZuqu83PK3RsTzqHA0pwxACe+gymm4S2giObFz/E44Ok4+uS mdVX6erzr+i11REFziSZYdhKGEK4Y3s7ic+nF/6ZKAIPLRcM4oRSWJRukC3MEKjnHhDt CA/EY9+qwz6QaZ2puQz/hm1uxxa1BLnLXfaZtBTJyu9lvB8eGGmz+1xilw0KB8kWx9aN hJDC6PF5DtXOJ3NDIKXvU6CfNqj5NAoOXgSkA1MnfK09Uk5g6F48BruDP+J0EElpQJVX +MRg== X-Gm-Message-State: ACgBeo2nvKLQzyhQtFplI/r1wiiwRfv3r8h7dfkVyk1cGvOvkVX/WDIn WSeIS5ciPTJ7lYpqtKGqNKs= X-Google-Smtp-Source: AA6agR6B4tH3eK4Y54CkuUjJKbd3dEFPz1pqldonbOLjL2+uhHfdkvYFwzjC+vGTOdsiEE7YlQ/JjQ== X-Received: by 2002:a17:902:e788:b0:16e:f924:6e41 with SMTP id cp8-20020a170902e78800b0016ef9246e41mr20279214plb.69.1660623907926; Mon, 15 Aug 2022 21:25:07 -0700 (PDT) Received: from localhost ([115.154.175.57]) by smtp.gmail.com with ESMTPSA id b2-20020a170902d50200b0016bef6f6903sm7861246plg.72.2022.08.15.21.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 21:25:07 -0700 (PDT) From: Ihor Radchenko To: Jack Kamm Cc: emacs-orgmode@gnu.org, gustav@whil.se Subject: Re: Bug? org-id-find not finding some IDs In-Reply-To: <87mtc6ohhx.fsf@gmail.com> References: <87r11zifjy.fsf@gmail.com> <87v8r8hhk2.fsf@localhost> <87r11vmf1o.fsf@gmail.com> <87r11un9in.fsf@localhost> <87mtc6ohhx.fsf@gmail.com> Date: Tue, 16 Aug 2022 12:26:12 +0800 Message-ID: <87y1vozue3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=yantar92@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660623945; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ko39QgsMJHx85juJjG/HRSeGrKb8I9LPRutFcqLHTf4=; b=HXO519/HUaEalLUbxPmWWQ1r3L86INXgoit/fpQzZfJL4ilDiGYRxLZkEKSOIfDxNubZ78 J45fbyr5CHIZrr8du2/8wruAqQMgCeuM09g5XMkcmrx9EmTjh06ZAIj0cXC81cjig+6W/2 yQj0fGy+oz16feKPrz6iNwDuzYQ5xPldAK+0qiWxpXMG19uVzgrf+z65gvmoLhBcae88Yh Vam6jDQs86693JTnDEU7Tx7KVahQoNx9cath7jcAWUcTgMihd3f2BS7sHsE4SoJmaKORAd xLUeBA7gIq8AJPhBGKYLMFPtrB5L+NArSICCJ4RLFEgusEIxR+DumUUGo1/EoQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660623945; a=rsa-sha256; cv=none; b=Z9nC/NIBZL7rsv+ofaIdVg0L+kn9GTdVh8hMzWNfaTuq8XNNReGYMF1IFWxd/+hOjPwFic S9n/T64Qnhh5UaGBWA84284yo4Itm/AEy4dFWkujykdIUtvwDXjob9Iqxm7tCrgbbr/cvT aXc5O8nOQwG7JZsqkeqy5sGAWVL+hYR/bmPmdV5BSquxbhiwjEmmdmlWyVu5cwqMKGZgBS +LYZ9XdNEN+rMOPPyeJ0HcpXatdTdhgkG1rmKnNyzzxQHvtM/beOF3OUFZ0G9hsLm3d5W1 Prkk+VRtb9O8cAKI4TbWJzO6KyzogArIFzaqs6qELoGeKZ0aoGQv1XJexhlr0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Pj/R8Adw"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.36 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Pj/R8Adw"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0067B6EBC X-Spam-Score: -3.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: v/c0BgAE1nSY Jack Kamm writes: > Ihor Radchenko writes: > >> Applied onto main via 8f5bf1725. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8f5bf172556564df89fb16ce8ecec68c5b7f0221 > > My sincere apologies, but after a bit of testing, I found that my > requested change had some unforeseen consequences, and I don't think > it's a good idea anymore. So, I'd like to request reverting it. > > Doing some research, I found the behavior of org-id-update-id-locations, > to not search all the open Org files, was made in this 2019 commit: > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9865e6bd8be65229be4eac4f459f62e47fab2be7 > > The commit message suggests this change in behavior was > intentional. Only, the docstring of org-id-extra-files wasn't updated to > reflect the new behavior, which was the cause of confusion on my end. That particular change has not been noticed in the relevant ML thread. I disagree that skipping the open ID files is the right decision. We already have org-id-get unconditionally adding arbitrary files to the ID locations. This org-id-get can be triggered in various unpredictable places inside Org and third-party packages. Thus, we cannot really expect consistency even after reverting the commit. > In terms of unforeseen consequences of the new commit: I found it caused > some problems for org-caldav. When making changes, org-caldav copies > entries into a backup file at ~/.emacs.d/org-caldav-backup.org. With the > new commit, it is sometimes finding entries in this backup file instead > of the correct file. I suggest to bind org-id-track-globally to nil file-locally in that backup file. I believe that org-id-track-globally, when set to t, is expected to catch all the Org files in Emacs + user-specified files. Skipping some opened files unpredictably, like it was done before my commit is chaotic and also caused confusion in this area in my own Org usage. If necessary, we may add an extra customization like org-id-exclude-files to explicitly exclude files from ID tracking. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92