emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 0/2] Don't print arguments of post-process arguments to stdout
Date: Fri, 07 Oct 2022 13:55:44 +0800	[thread overview]
Message-ID: <87y1tskwin.fsf@localhost> (raw)
In-Reply-To: <20221006114346.23926-1-jonas@bernoul.li>

Jonas Bernoulli <jonas@bernoul.li> writes:

> I run org-babel-execute-buffer from a Makefile and the output is quite
> noisy, forcing me to filter out some output using grep -v so that I am
> still able to spot any unexpected output that indicates some issue.
>
> Now that I have started using post-processing code blocks, the output
> has gotten even more noisy and unfortunately filtering out the unwanted
> additions is not possible.
>
> Currently all arguments to post-processing blocks are printed to
> stdout.  I am not able to filter them out using grep because this
> output seems to be split across multiple lines, so a regexp like
> "^(" only matches parts of the noise.
>
> It is unclear whether the arguments were printed on purpose.  It might
> be useful to do so at times for debugging purposes, but generally they
> make things harder, by obscuring output one would want to notice.

I suspect that it is remnants of previous code re-factoring in
5e0db0798. The old code used `print' for pretty-printing :results pp.

> The second commit addresses a cosmetic, but somewhat related,
> annoyance.
>
> Jonas Bernoulli (2):
>   Don't print arguments of post-process arguments to stdout
>   Begin messages about executing code blocks with a capital letter
>
>  lisp/ob-awk.el        | 2 +-
>  lisp/ob-core.el       | 2 +-
>  lisp/ob-emacs-lisp.el | 2 +-
>  lisp/ob-groovy.el     | 2 +-
>  lisp/ob-maxima.el     | 2 +-
>  lisp/ob-sed.el        | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)

Applied onto main with amendments to commit messages.
Please refer to
https://orgmode.org/worg/org-contribute.html#commit-messages in future.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2f4de60980b6b10770696c4ee0b610d0e96ab575
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fc8e375b9bd2685690e6ec9f0cc6ed078a6e938f

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      parent reply	other threads:[~2022-10-07  5:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 11:43 [PATCH 0/2] Don't print arguments of post-process arguments to stdout Jonas Bernoulli
2022-10-06 11:43 ` [PATCH 1/2] " Jonas Bernoulli
2022-10-06 11:43 ` [PATCH 2/2] Begin messages about executing code blocks with a capital letter Jonas Bernoulli
2022-10-07  5:55 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1tskwin.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jonas@bernoul.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).