From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id CIXgN1aNMmbzWgAAe85BDQ:P1 (envelope-from ) for ; Wed, 01 May 2024 20:43:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id CIXgN1aNMmbzWgAAe85BDQ (envelope-from ) for ; Wed, 01 May 2024 20:43:35 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=iVg4ZpPy; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714589014; a=rsa-sha256; cv=none; b=hDhmAWYd/mG3KbHnPYl5ItxvfqirxmNaVY+PbVdiCM/eC9THX3wPwLJjufH877cGBfMR9r uQVqesJyGX7tiw6Sl+5FySLZf3D9Hzi7bYKQxBl2lBzdR4c+1LqsP9/5Opp6h7OJzcmkCZ j6J7tEPeamBKT9qjDBW25ecVAYXE4zHDLh47khdqtxXbmobNRcycP1P/EBpa/LyuGz3SYd 6QP9dsxfvMegtgRzRd+Pm/eeI8283aG86F9Eez9eVfTGYBTRpiWfB2BkvchTSDzQ2Y6EBu i/VusAVS4w7eueEwqfUv5cK/nFkqkzWCu4w/5iZ/+ShrUTWFrk53zWRHycRnQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=iVg4ZpPy; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714589014; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cTSUqV/Jx685FaJvPr59ENIF9TImBa6nqZvvfNFx2eQ=; b=GM8Y96m55dryKcmtEcw01ngGNH+2WMSDLIXucoPH7RGttVP5j5FXA1z3ULH3oshxXEds1P EKsUyh6jCdpSM3qfbELYRKEOpWQLBWQ6wkO2tQilX+ZtxAlsRvuCau8FF0geGPMqzGNXiw idAmG0StntsjVXr5rDonChwWJTytXmHvLWpZdjDfaQiOiiHwkWiPI/Nl1ou2iqjBK80MES LXEyISs2wJbrB684tpuotdz/Cs8udtzRFsBkFtTkNPAhIWUETPPdV7r6S0FnwUzoMvXtx8 FpT1WKk1/XQP4GkzRUfFPDZbmvDgYBrU5XgDJ/K/j6g0i1atVQbsHyLy3goShg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B92BA66552 for ; Wed, 1 May 2024 20:43:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2Euj-0003qI-0d; Wed, 01 May 2024 14:42:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Eug-0003q1-4i for emacs-orgmode@gnu.org; Wed, 01 May 2024 14:42:43 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Eud-0005sq-KS for emacs-orgmode@gnu.org; Wed, 01 May 2024 14:42:41 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 53C38240033 for ; Wed, 1 May 2024 20:42:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714588957; bh=ldAwCyYu9ckY7BugzjgDfmxN5pLC4sq8SQyQQ3Qtr+Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=iVg4ZpPyPc5UVOfZyc4hHRd13CkiSH2rJmfEFOzVEAgiGJFkGPXyRBezSSaM0WLzq 0816tgHWfyihbSTYbuX101qyBwxHNnUzbGW41cCUl6Rb4mUbDwNeo2kC2VnXEd8wyL bLXG4JS5RHAmJ8gog61a/pXbFoAo7x1ESq03/PtfFAxndnQhvJKBqnwoh4uMff42Vx YT9rlQTRlvV9DNzhwpj52e+LImghQWLszkfaxlemzpTiAGKNpZnLytEMrDhJuWd6vX 2e/yBE7cgeF4wjNCTeAnirrCqdPPRRXjaLNyp56M8PZWTMSAo2QUzXlMknJXvZmubG 9D7uWeNT/tA8w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VV5XX5QJ7z9rxB; Wed, 1 May 2024 20:42:36 +0200 (CEST) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get' In-Reply-To: References: <87ttjkaywn.fsf@localhost> <877cgfywwg.fsf@localhost> Date: Wed, 01 May 2024 18:43:44 +0000 Message-ID: <87y18tqsnz.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: B92BA66552 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.77 X-Spam-Score: -8.77 X-TUID: dSqoHXYuOlu5 Morgan Smith writes: >> Also, with the old approach, if you observe slowdowns, you likely have >> some property being calculated slowly (like BLOCKED in my case). Do you >> happen to know which property is it for your setup? > > According to my profiler, I think it's using 30% of the CPU time during > my custom org-clock-sum just to get ITEM. I suppose it's because it > thinks it has to grab and cache everything when all I'm after is ITEM. Not sure here. Getting ITEM is just a single regexp match. May you share the profiler report? (M-x profiler-report-write-profile) > I don't see anything else that looks suspicious in the profiler so I > suspect you're seeing a much worse case then I am. I'll copy paste my > previous performance numbers here again just so you can see my slowdown > is only between 1.5x and 3x. In my case it was more like 10x :) > * lisp/org.el (org-make-tags-matcher): Replace uses of > `org-cached-entry-get' with `org-entry-get'. > (org-cached-entry-get): Move to ... > * lisp/org-compat.el (org-cached-entry-get): ... here. Obsolete in > favor of `org-entry-get'. Applied, onto main, after adding missing declare statements to pacify the compiler. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=646f6ec13 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at