emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Smith <morgan.j.smith@outlook.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get'
Date: Wed, 01 May 2024 18:43:44 +0000	[thread overview]
Message-ID: <87y18tqsnz.fsf@localhost> (raw)
In-Reply-To: <CH3PR84MB342490FB7A24C4C9EB5EDC4BC5192@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM>

Morgan Smith <morgan.j.smith@outlook.com> writes:
>> Also, with the old approach, if you observe slowdowns, you likely have
>> some property being calculated slowly (like BLOCKED in my case). Do you
>> happen to know which property is it for your setup?
>
> According to my profiler, I think it's using 30% of the CPU time during
> my custom org-clock-sum just to get ITEM.  I suppose it's because it
> thinks it has to grab and cache everything when all I'm after is ITEM.

Not sure here. Getting ITEM is just a single regexp match.
May you share the profiler report? (M-x profiler-report-write-profile)

> I don't see anything else that looks suspicious in the profiler so I
> suspect you're seeing a much worse case then I am.  I'll copy paste my
> previous performance numbers here again just so you can see my slowdown
> is only between 1.5x and 3x.

In my case it was more like 10x :)

> * lisp/org.el (org-make-tags-matcher): Replace uses of
> `org-cached-entry-get' with `org-entry-get'.
> (org-cached-entry-get): Move to ...
> * lisp/org-compat.el (org-cached-entry-get): ... here.  Obsolete in
> favor of `org-entry-get'.

Applied, onto main, after adding missing declare statements to pacify
the compiler.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=646f6ec13

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-05-01 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  0:28 [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get' Morgan Smith
2024-04-29 16:58 ` Ihor Radchenko
2024-04-29 18:36   ` Morgan Smith
2024-04-30 10:20     ` Ihor Radchenko
2024-05-01 17:14       ` Morgan Smith
2024-05-01 18:43         ` Ihor Radchenko [this message]
2024-05-01 19:33           ` Morgan Smith
2024-05-01 20:49             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y18tqsnz.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=morgan.j.smith@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).