emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Raffael Stocker <r.stocker@mnet-mail.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Incorrect time calculation in agenda clockcheck
Date: Fri, 17 May 2024 11:45:32 +0000	[thread overview]
Message-ID: <87y1888xwj.fsf@localhost> (raw)
In-Reply-To: <yplmzfsrqjw6.fsf@mnet-mail.de>

Raffael Stocker <r.stocker@mnet-mail.de> writes:

> in the Org Agenda clockcheck view, a warning about missing end time of a
> clocked-in task is displayed together with the already elapsed time of
> that task.  If the starting time is in the future (this can happen if
> rounding and continuous clocking are used), the elapsed time is
> incorrect.  For example, if a clocked-in task starts in 5 minutes,
> clockcheck will report something like "No end time: (0:55)".  It would
> be more sensible to say "No end time: (-0:05)" or even "No end time: (in
> 0:05)".

Thanks for reporting!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ee58259bc

> The culprit is the use of ‘org-duration-from-minutes’ in
> ‘org-agenda-show-clocking-issues’, because org-duration always assumes
> positive durations and is given a negative one here.  The problem can
> easily be corrected with something like the following:
>...
> However, I believe it would be more useful (and general) to use a
> similar trick to teach org-duration to work with negative durations.

That's what I ended up doing.

> ... It would be more sensible to ... or even "No end time: (in 0:05)".

I find this confusing, so I left -0:05.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-05-17 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 13:34 [BUG] Incorrect time calculation in agenda clockcheck Raffael Stocker
2024-05-17 11:45 ` Ihor Radchenko [this message]
2024-05-17 13:43   ` Mnet-Mail

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1888xwj.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=r.stocker@mnet-mail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).