emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Joseph Turner <joseph@breatheoutbreathe.in>
To: Org Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] lisp/org.el: Fix removing timestamp overlays
Date: Sun, 25 Aug 2024 22:03:38 -0700	[thread overview]
Message-ID: <87y14j7u51.fsf@breatheoutbreathe.in> (raw)
In-Reply-To: <874j779ali.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 25 Aug 2024 21:22:49 -0700")

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Joseph Turner <joseph@breatheoutbreathe.in> writes:

> Thank you!  Cheers!  -Joseph
>
> [2. text/x-diff; 0001-lisp-org.el-Fix-removing-timestamp-overlays.patch]...

Woops!  The 'display text property may be symbol or list - here's a
better patch.

Thanks,

Joseph


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org.el-Fix-removing-timestamp-overlays.patch --]
[-- Type: text/x-diff, Size: 863 bytes --]

From 9351b3c8f960ac6d2fba3c2de0c46e8474719582 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Sun, 25 Aug 2024 21:20:06 -0700
Subject: [PATCH] lisp/org.el: Fix removing timestamp overlays

---
 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index d5c1dcb35..24a32227c 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14614,7 +14614,7 @@ (defun org-toggle-timestamp-overlays ()
     (let ((p (point-min)) (bmp (buffer-modified-p)))
       (while (setq p (next-single-property-change p 'display))
 	(when (and (get-text-property p 'display)
-		   (eq (get-text-property p 'face) 'org-date))
+		   (memq 'org-date (ensure-list (get-text-property p 'face))))
 	  (remove-text-properties
 	   p (setq p (next-single-property-change p 'display))
 	   '(display t))))
-- 
2.41.0


  reply	other threads:[~2024-08-26  5:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26  4:22 [PATCH] lisp/org.el: Fix removing timestamp overlays Joseph Turner
2024-08-26  5:03 ` Joseph Turner [this message]
2024-09-01 14:55   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y14j7u51.fsf@breatheoutbreathe.in \
    --to=joseph@breatheoutbreathe.in \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).