[PATCH] Remove Emacs<24.4 compatibility code

[PATCH] Remove Emacs<24.4 compatibility code

[Morgan Smith]

* lisp/org-goto.el: Don't conditionally define keys based on if
`isearch-other-control-char' is bound.

Org mode only supports Emacs 27 and later.
---
 lisp/org-goto.el | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/lisp/org-goto.el b/lisp/org-goto.el
index f75cc9ed8..aa2a9328a 100644
--- a/lisp/org-goto.el
+++ b/lisp/org-goto.el
@@ -134,14 +134,9 @@ When nil, you can use these keybindings to navigate the buffer:
 	  (org-defkey map "\C-c\C-u" 'outline-up-heading)
 	  map)))
 
-;; `isearch-other-control-char' was removed in Emacs 24.4.
-(if (fboundp 'isearch-other-control-char)
-    (progn
-      (define-key org-goto-local-auto-isearch-map "\C-i" 'isearch-other-control-char)
-      (define-key org-goto-local-auto-isearch-map "\C-m" 'isearch-other-control-char))
-  (define-key org-goto-local-auto-isearch-map "\C-i" nil)
-  (define-key org-goto-local-auto-isearch-map "\C-m" nil)
-  (define-key org-goto-local-auto-isearch-map [return] nil))
+(define-key org-goto-local-auto-isearch-map "\C-i" nil)
+(define-key org-goto-local-auto-isearch-map "\C-m" nil)
+(define-key org-goto-local-auto-isearch-map [return] nil)
 
 (defun org-goto--local-search-headings (string bound noerror)
   "Search and make sure that any matches are in headlines."
-- 
2.46.0

Re: [PATCH] Remove Emacs<24.4 compatibility code

[Ihor Radchenko]

Morgan Smith <Morgan.J.Smith@outlook.com> writes:

> * lisp/org-goto.el: Don't conditionally define keys based on if
> `isearch-other-control-char' is bound.
>
> Org mode only supports Emacs 27 and later.

Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6f00a8348b

We usually keep the old compatibility code in place, unless there is a
clear reason to remove it (e.g. it stays on the way of new
features/improvements). On the other hand, we do not hold on to it
either. So, I accepted this patch.

If you are interested to contribute to Org mode, do note that removing
obsolete compatibility code is one of the lowest priority items among
possible improvements to Org. There are plenty of other places where Org
codebase can use some cleanup.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>