From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id eKBSFzYFbGe/TQAAqHPOHw:P1 (envelope-from ) for ; Wed, 25 Dec 2024 13:14:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id eKBSFzYFbGe/TQAAqHPOHw (envelope-from ) for ; Wed, 25 Dec 2024 14:14:30 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="B0Ht/Pan"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735132469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=A9JjsGygZ/VTVaigIL9EGU1anVyyG76fkrs9jmczrXw=; b=QnXkk6QPx6E2JtScgo8I/drN317+0kBNU47c1xpXyxyH5JjyMTJ4RwblxxKeNKUEiEVeLk snw67e/4XXdu3nVcCeqXU3GYTVRxxDMxipB9zFzRueLB5DvPxuIGXm9bgXVZUxR8uPrcko 0f1iPy7rKIS+zIlgIx6HZhnQij4mPThYfbG8RYUUASSXjivl7vrji7Nn08TD5hX2ElvFtN 75bgvxzL3Kdio5V3cq1+bW/tojOXhzcy1pRDjZAfbX4sQYyY6X21QB8g8Unozki+r615l9 A/bIexelgOKzMMu5fys3qIkMX7dLaB51/91wP+8a6GEvRKY34MwtZGdfBPDyeg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="B0Ht/Pan"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735132469; a=rsa-sha256; cv=none; b=frQP+DIpvbjQbaEWx3e6WKTB/Rp3KjSuPYgWCbTPM2vQV8gBeTqlAtWRejaDu1IUOnakCu NaSoHQZIOoLJGvsAbR7AETzwe8NxYEkh6XEjNFLbMvq0oN3jDZCX/wiOeQGXzCXta7dQWa TfoF7EAYkwYfPAddONznfaojlHNELF1NRNS3h33CHxjxnO2BJwTHGS1YV3TYvBfgNMfMdD bYJSCxl7OzxcdM1MKnNjHiwCvzHfnG6AIzDnFSYRMtrsa6dAfTtbJw17rYC77brV7QPzQD mULkzYaCednfXmgSwwKnCznm1Vr9NXXoB2++KVAoSRNanksRg6GHs/637EM1Gg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D7E9189099 for ; Wed, 25 Dec 2024 14:14:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQRCn-0006w1-Lw; Wed, 25 Dec 2024 08:13:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQRCi-0006v0-Pk for emacs-orgmode@gnu.org; Wed, 25 Dec 2024 08:13:37 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQRCd-0002YR-AE for emacs-orgmode@gnu.org; Wed, 25 Dec 2024 08:13:34 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9A5F2240101 for ; Wed, 25 Dec 2024 14:13:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735132408; bh=orOykA275yYlHUtYZDkR/GhCd3EY3hox55x/iL7F9Po=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=B0Ht/PanY/pr3NlP54w6PQDuU8oR7gn3ts28OQlLr84Sa8/9uQLar5U9pNK3477uL R7KgAotVYgEISTowAxoCAEGbEoR/sXPXBROg14iZyJiaOnkm4whmpb+jaP7Ji4dUZl l8ZEro2b8KsGJDep5oluG5W7Y+BIp7fXcFfeWx3l7T9cbLkduLiTy7MATcUp/Y/F4i Tv1Gthp8IvbMyxn5H0LfiHmV236BravI9FcyfqX3odofEU5jeWeSYaTxzdv2t0wkBE +ds89UzkcJAfFqGJu80QJsVJbC72aa76wuX+w0PiygpMGApwvRrloA9izWLDhr3BW2 dEBBJtZL1ByBQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YJByw1xdTz9rxB; Wed, 25 Dec 2024 14:13:28 +0100 (CET) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Remove Emacs<24.4 compatibility code In-Reply-To: References: Date: Wed, 25 Dec 2024 13:14:59 +0000 Message-ID: <87y103zyy4.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -6.18 X-Spam-Score: -6.18 X-Migadu-Queue-Id: D7E9189099 X-TUID: Q2Ec+XwsSEDO Morgan Smith writes: > * lisp/org-goto.el: Don't conditionally define keys based on if > `isearch-other-control-char' is bound. > > Org mode only supports Emacs 27 and later. Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6f00a8348b We usually keep the old compatibility code in place, unless there is a clear reason to remove it (e.g. it stays on the way of new features/improvements). On the other hand, we do not hold on to it either. So, I accepted this patch. If you are interested to contribute to Org mode, do note that removing obsolete compatibility code is one of the lowest priority items among possible improvements to Org. There are plenty of other places where Org codebase can use some cleanup. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at