From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wGFdIcGkbWeNZgEAqHPOHw:P1 (envelope-from ) for ; Thu, 26 Dec 2024 18:47:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wGFdIcGkbWeNZgEAqHPOHw (envelope-from ) for ; Thu, 26 Dec 2024 19:47:29 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hRKny3Jd; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735238849; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4JOwU+MtnKcxmpHunbPATBBvfLgQFjTGajwyhcAxEck=; b=mGVCFYL0ydCU9IqvJCsL1yfWrMGw/aBh7boTU2QyaRGTqyco85RtLIdlLn8uwRFHdCbeqA giUbr8+Gp7ZGR5aFIjdRiaRNQLs/yV4WsC+PJi53F0Ke/ZsZqT7DZgIHVq80YiwNtCGYdT H81r1G9NeuSNyCk8C9FqV3Tl1cZSZHtgZAh4aK6aOlhXT0P+jZ+EGWE/0r1R7hytgC2odj Ppr8L92rXPqeTC+Q6emmCfAP6CS6dr8be0YW2xLVoIo0nCClf4VJHEmKlP0pZHdzc5O5Js pqu0k/PAOKn5manAiM/QFfjAiMEJwfE6FfYjKySn9u8DNuE++2B0ni3TsqOx0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hRKny3Jd; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735238849; a=rsa-sha256; cv=none; b=sxDL63kTSYflCFLWTsp+hTsKB01ZtSg2UJ95+R/smVj2SY4LdD3uB+63kOo79qvNsOG1dF fhYXyPm0ZWejXegXAkvpcZ0oZENdAI/mg+gG3NPaCTYZYE8o3N/rrcMOLCsD8pbM5B7ZIf vFWL4dxrFgfBTZuWMyI1JYDximLCpBqZ9REq/5HK9ZTjYQF8hgj7jMrm9HqlN0O+XxxVaj Xamk/7VKOvfUCKFxFvDJ25cjix+6MWsDAGct1ZBf13U7bajrwFduD79D32S3Z18fQ2pKEd fc8+B4fWAfSEQUt9bDadBsG6R6jZTOPLs6k6IucMNV4vCKeRYNJvKYaB3gZCnQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 725F17F4DF for ; Thu, 26 Dec 2024 19:47:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQssj-0006gf-NP; Thu, 26 Dec 2024 13:46:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQssZ-0006gI-3T for emacs-orgmode@gnu.org; Thu, 26 Dec 2024 13:46:40 -0500 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQssX-0002ol-Ih for emacs-orgmode@gnu.org; Thu, 26 Dec 2024 13:46:38 -0500 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-2ef72924e53so7845440a91.3 for ; Thu, 26 Dec 2024 10:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735238796; x=1735843596; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4JOwU+MtnKcxmpHunbPATBBvfLgQFjTGajwyhcAxEck=; b=hRKny3JdI5ql1hIBt6LMoyoZ8OVxqkhUPSEAIyBE0Fb04seupo/a+zTq8EklzaxJJn 6jm9xAA5Y4XsKqBz6tUw2b7EwKgcRjDE2xzLNJCFTLaX5RvGgEnhqO9qf0+tOsiiSN7q 8h8vTNOpUlTGIKxjj3OMRRB8KQ+yAgNIHgrL/PkfgP7hAA5EWxB/rvJME61USM/PnJwc kOqxBi89Tpdcm3wwxaCJyv/a2CpVpv3CkBgi8Ei/rEAP4DcjVTXE3ZORl0VOYhIZkg71 9RDZC0k5eZAVH1jWRDFASgpXlv1BPYhOkM6wgjkuZ2KD3tZkrhxvkA8UyXPebemb/YVj DkYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735238796; x=1735843596; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4JOwU+MtnKcxmpHunbPATBBvfLgQFjTGajwyhcAxEck=; b=CVAqoLNl23LsiyqzrEX7YScq8j273zchiYZU0Tbqv7oVH4RQuVyE0BLgLiUhDwkUJb uRiIcJqUlteX9D/Clxy11gKlLbPsksDSlXEHqEonkQOKvqndp6tJX3s15Wc6NNBIeqsy jHDMXfd5WQWNpBaCQLIYHL8Zv3dRIwDOyDK8IsUH7n1SiB9xObwK8SuxWmWxcN1P7U7V zYMlavHFi61kqmFwzHlp8DWAaWgtLeAvjHB77Mv/LQig1HMfD2aQmi7xy5NKweyA4Y5Q MGK2dY4mt5/nAV/6jfMgrbPVt0+44qBeZmEXROxBWUc3yN79h12oHAnK6cDNH2fLQ6xb QS0A== X-Gm-Message-State: AOJu0Yz/ovlOG8HfTVQl7bCRNaBWendSznfVyS0xRUTdIo9A43cK7Wrj nwov+52u60J1QsmAdJ2snU5o2ZygBjZGCbOniYIza1UAomhCCzwtdzKspA== X-Gm-Gg: ASbGncvAL2tHDVkOlpsKMWV2RgOnZZWiYklhhWqf6nmAoZuunRe9H+iSF3OTKRZnw/y DJgr10TOlYv8IUI1fer9wZsnU8ESYs8bQMqrgURbEvTbElRQplb0BeqGxUxP9MSSBLUgFSqbIvD ghSWj3CbhtcCJCyTwSn5RI5rlPeTFcU9C6u6VZv49F+8vNnRUhqXu35CAeRxuQzf/r7Ixw7KrkG oe1srGLxWmxpKdhMYCLaQg0F5tZgtO8Pe0pEp+o9hi1BfJaZpV7P7w1t/3BwgdS2NrHCQ== X-Google-Smtp-Source: AGHT+IEUHGaC8nUX5/a3Gb9czJ3F0IswcMOyk8RkeZQ8295+MYMKLZ1X7faeteDPrqSxJP+J3S0p+w== X-Received: by 2002:a17:90b:1346:b0:2f2:8bdd:cd8b with SMTP id 98e67ed59e1d1-2f452ee828dmr37388858a91.29.1735238795702; Thu, 26 Dec 2024 10:46:35 -0800 (PST) Received: from localhost ([2600:8802:5726:2500:b0ad:16dc:5de1:fa47]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f4476c04a5sm14332618a91.0.2024.12.26.10.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 10:46:34 -0800 (PST) From: Karthik Chikmagalur To: =?utf-8?Q?Bj=C3=B6rn?= Bidar , Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: Link preview generation with new link preview property In-Reply-To: <6764aa79.050a0220.23273b.09a5SMTPIN_ADDED_BROKEN@mx.google.com> References: <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com> <874j382kue.fsf@gmail.com> <87pllug2y4.fsf@localhost> <87ldwfnff4.fsf@gmail.com> <874j328aym.fsf@localhost> <6764aa79.050a0220.23273b.09a5SMTPIN_ADDED_BROKEN@mx.google.com> Date: Thu, 26 Dec 2024 10:46:34 -0800 Message-ID: <87y102mgdx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=karthikchikmagalur@gmail.com; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 725F17F4DF X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.39 X-Spam-Score: -4.39 X-TUID: e49OSRmafSRW >>> ... >>> Considering this, it might be better to just split >>> `org-link-preview-file' into two public functions, where the "inside" >>> function accepts an image instead of a file. >> >> Agree. >> Would you be interested to create a patch? > > Did you think of something like this? It looks like you are respecting the alignment specifications, set via org-image-align or the :align property of #+attr_*, but not the :width property. Is the idea that the preview implementation that provides the image should independently use org-display-inline-image--width? At minimum this requires making org-display-inline-image--width a public function. But it would be good for org-link-preview-image-data to respect both properties. Karthik