From: Richard KLINDA <rklinda@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-clock-select-task bugfix (XEmacs incompatibility)
Date: Wed, 02 Dec 2009 13:32:37 +0100 [thread overview]
Message-ID: <87ws15blp6.fsf@gmail.com> (raw)
In-Reply-To: <252E914A-E305-4841-B39E-470700D355F6@gmail.com> (Carsten Dominik's message of "Wed, 2 Dec 2009 06:41:32 +0100")
Hello Carsten, this failed for me ever since, but as I haven't needed
the functionality I was just lazy to report it. Oh:) I see why my patch
must be problematic, sorry about that.
The problem is that, when pressed a number as a reply to the question,
this cond command (see below) always goes to the error clause, because
rpl gets the value of ?1 for example, but sel-list look like ((49 . ...)
(50 . ...)) so the assoc can't find ?1. With my patch, the assoc finds
it because rpl is converted to ASCII code, but now ?q and ?x clauses
don't work.:)
(cond
((eq rpl ?q) nil)
((eq rpl ?x) nil)
((assoc rpl sel-list) (cdr (assoc rpl sel-list)))
(t (error "Invalid task choice %c" rpl)))
I hope you see what the problem is, I think it must be an XEmacs issue.
>>>>> Regarding 'Re: [Orgmode] [PATCH] org-clock-select-task bugfix (XEmacs incompatibility)'; Carsten Dominik adds:
> Hi Richard, I don't see why this would be necessary? Under what
> circumstances does this fail?
> - Carsten
> On Dec 1, 2009, at 9:07 PM, Richard KLINDA wrote:
>> See attached simple patch.
>> From 795d529d622f509f47c2bf17a0139fbe1659cc5f Mon Sep 17 00:00:00
>> 2001 From: Richard Klinda <rklinda@gmail.com> Date: Tue, 1 Dec 2009
>> 21:03:39 +0100 Subject: [PATCH] org-clock: org-clock-select-task
>> bugfix (XEmacs)
>> --- lisp/org-clock.el | 4 ++++ 1 files changed, 4 insertions(+), 0
>> deletions(-)
>> diff --git a/lisp/org-clock.el b/lisp/org-clock.el index
>> 56dbab5..87017fc 100644
>> --- a/lisp/org-clock.el
>> +++ b/lisp/org-clock.el
>> @@ -344,6 +344,10 @@ of a different task.")
>> (org-fit-window-to-buffer) (message (or prompt "Select task for
>> clocking:")) (setq rpl (read-char-exclusive))
>> + (when (featurep 'xemacs)
>> + ;; in XEmacs read-char-exclusive returns character, instead
>> of
>> + ;; ascii value
>> + (setq rpl (char-octet rpl)))
>> (cond ((eq rpl ?q) nil) ((eq rpl ?x) nil) -- 1.6.2.1
>> -- Richard _______________________________________________
>> Emacs-orgmode mailing list Please use `Reply All' to send replies
>> to the list. Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> - Carsten
--
Richard
next prev parent reply other threads:[~2009-12-02 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 20:07 [PATCH] org-clock-select-task bugfix (XEmacs incompatibility) Richard KLINDA
2009-12-02 5:41 ` Carsten Dominik
2009-12-02 12:32 ` Richard KLINDA [this message]
2009-12-03 11:47 ` Carsten Dominik
2009-12-03 12:41 ` Richard KLINDA
2009-12-03 13:54 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws15blp6.fsf@gmail.com \
--to=rklinda@gmail.com \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).