From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Bug: Infinite loop in `org-previous-item' when there's nothing above item (patch included) [6.33trans (release_6.33f.80.gb777e3)] Date: Sat, 05 Dec 2009 22:03:29 +0100 Message-ID: <87ws11xhem.wl%maus.david@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Sat_Dec__5_22:03:29_2009-1" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NH1nD-00050P-HR for emacs-orgmode@gnu.org; Sat, 05 Dec 2009 16:03:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NH1n8-0004t4-IU for emacs-orgmode@gnu.org; Sat, 05 Dec 2009 16:03:51 -0500 Received: from [199.232.76.173] (port=36727 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NH1n8-0004sj-5p for emacs-orgmode@gnu.org; Sat, 05 Dec 2009 16:03:46 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:47741) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NH1n7-0001Si-Jw for emacs-orgmode@gnu.org; Sat, 05 Dec 2009 16:03:45 -0500 Received: by bwz7 with SMTP id 7so2998181bwz.26 for ; Sat, 05 Dec 2009 13:03:44 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --Multipart_Sat_Dec__5_22:03:29_2009-1 Content-Type: text/plain; charset=US-ASCII Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See http://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org-mode mailing list. ------------------------------------------------------------------------ When `org-previous-item' is called on an item with nothing above it Orgmode enters an infinite loop. The reason is that `org-previous-item' searches for non-empty lines by moving point up line by line and if there is nothing above an item point gets stuck on begin of buffer. example.org ,---- | | - Item `---- Move point on Item, M-x org-previous-item RET and Orgmode enters the infinite loop. Attached patch adds a conditional clause to `org-previous-item' that leaves the search loop if point reaches beginning of buffer. Emacs : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3) of 2009-11-28 on elegiac, modified by Debian Package: Org-mode version 6.33trans (release_6.33f.80.gb777e3) --Multipart_Sat_Dec__5_22:03:29_2009-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="0001-org-list.el-Prevent-infinite-loop-in-org-previous-it.patch" Content-Transfer-Encoding: base64 RnJvbSBiNzc3ZTM5NjkzNzJmMjNlZDM1N2JkZDQwNThjMTQ0NWNjZmU1ZDM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBNYXVzIDxtYXVzLmRhdmlkQGdtYWlsLmNvbT4KRGF0 ZTogU2F0LCA1IERlYyAyMDA5IDIxOjU2OjM0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gb3JnLWxp c3QuZWw6IFByZXZlbnQgaW5maW5pdGUgbG9vcCBpbiBgb3JnLXByZXZpb3VzLWl0ZW0nCgpXaGVu IGBvcmctcHJldmlvdXMtaXRlbScgaXMgY2FsbGVkIG9uIGFuIGl0ZW0gd2l0aCBub3RoaW5nIGFi b3ZlIGl0Ck9yZ21vZGUgZW50ZXJzIGFuIGluZmluaXRlIGxvb3AuIFRoZSByZWFzb24gaXMgdGhh dApgb3JnLXByZXZpb3VzLWl0ZW0nIHNlYXJjaGVzIGZvciBub24tZW1wdHkgbGluZXMgYnkgbW92 aW5nIHBvaW50IHVwCmxpbmUgYnkgbGluZSBhbmQgaWYgdGhlcmUgaXMgbm90aGluZyBhYm92ZSBh biBpdGVtIHBvaW50IGdldHMgc3R1Y2sgb24KYmVnaW4gb2YgYnVmZmVyLgoKUGF0Y2ggYWRkcyBh IGNvbmRpdGlvbmFsIGNsYXVzZSB0aGF0IGxlYXZlcyB0aGUgc2VhcmNoIGxvb3AgaWYgcG9pbnQK cmVhY2hlcyBiZWdpbm5pbmcgb2YgYnVmZmVyLgotLS0KIGxpc3Avb3JnLWxpc3QuZWwgfCAgICAz ICsrLQogMSBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvbGlzcC9vcmctbGlzdC5lbCBiL2xpc3Avb3JnLWxpc3QuZWwKaW5kZXggZWRk NjEyYS4uNTZjYmM0MiAxMDA2NDQKLS0tIGEvbGlzcC9vcmctbGlzdC5lbAorKysgYi9saXNwL29y Zy1saXN0LmVsCkBAIC02MTYsNyArNjE2LDggQEAgRXJyb3IgaWYgbm90IGF0IGEgcGxhaW4gbGlz dCwgb3IgaWYgdGhpcyBpcyB0aGUgZmlyc3QgaXRlbSBpbiB0aGUgbGlzdC4iCiAJKGlmIChsb29r aW5nLWF0ICJbIFx0XSokIikKIAkgICAgbmlsCiAJICAoaWYgKDw9IChzZXRxIGluZDEgKG9yZy1n ZXQtaW5kZW50YXRpb24pKSBpbmQpCi0JICAgICAgKHRocm93ICdleGl0IHQpKSkpKQorCSAgICAg ICh0aHJvdyAnZXhpdCB0KSkpCisJKGlmIChib2JwKSAodGhyb3cgJ2V4aXQgdCkpKSkKICAgICAo Y29uZGl0aW9uLWNhc2UgbmlsCiAJKGlmIChvciAobm90IChvcmctYXQtaXRlbS1wKSkKIAkJKDwg aW5kMSAoMS0gaW5kKSkpCi0tIAoxLjYuNQoK --Multipart_Sat_Dec__5_22:03:29_2009-1 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --Multipart_Sat_Dec__5_22:03:29_2009-1--