org-toggle-inline-images bug

org-toggle-inline-images bug

[William Xu]

Hi, 

M-x org-toggle-inline-images doesn't work for links like this: 
  [[./ref/diskStructures.png]]

The problem lies in `org-display-inline-images': 

  (let ((re (concat "\\[\\[\\(\\(file:\\)\\|\\([./~]\\)\\)\\([^]\n]+?"
    	(substring (org-image-file-name-regexp) 0 -2)
    	"\\)\\]" (if include-linked "" "\\]")))
    old file ov img)

org-image-file-name-regexp assumes the last two characters are "\\)\\'"
or "\\)\\$".  However, in its definition: 

  (defun org-image-file-name-regexp (&optional extensions)
    "Return regexp matching the file names of images.
  If EXTENSIONS is given, only match these."
    (if (and (not extensions) (fboundp 'image-file-name-regexp))
        (image-file-name-regexp)
    ;; snip 

When image-file-name-regexp is defined, (image-file-name-regexp) doesn't
ends with those two specific characters.  On my machine, it returns: 

(image-file-name-regexp)
=> 
"\\.\\(GIF\\|JP\\(?:E?G\\)\\|P\\(?:BM\\|GM\\|N[GM]\\|PM\\)\\|SVG\\|TIFF?\\|X\\(?:[BP]M\\)\\|gif\\|jp\\(?:e?g\\)\\|p\\(?:bm\\|gm\\|n[gm]\\|pm\\)\\|svg\\|tiff?\\|x\\(?:[bp]m\\)\\)\\'\\|\\.png$\\|\\.jpeg$\\|\\.jpg$\\|\\.gif$\\|\\.tiff$\\|\\.tif$\\|\\.xbm$\\|\\.xpm$\\|\\.pbm$\\|\\.pgm$\\|\\.ppm$\\|\\.pnm$"

Thus, the `re' match fails.  

Maybe we shall not depend on (image-file-name-regexp) ? 

-- 
William

http://xwl.appspot.com

Re: org-toggle-inline-images bug

[Bastien]

Hi William,

William Xu <william.xwl@gmail.com> writes:

> M-x org-toggle-inline-images doesn't work for links like this: 
>   [[./ref/diskStructures.png]]

It works well here on Emacs GNU Emacs 24.0.50.1 or 23.3.1 and 
Org 7.7 (latest git version.)

What version of Emacs and Org are you using?

Thanks,

-- 
 Bastien

Re: org-toggle-inline-images bug

[William Xu]

2011/8/25 Bastien <bzg@altern.org>:
> Hi William,
>
> William Xu <william.xwl@gmail.com> writes:
>
>> M-x org-toggle-inline-images doesn't work for links like this:
>>   [[./ref/diskStructures.png]]
>
> It works well here on Emacs GNU Emacs 24.0.50.1 or 23.3.1 and
> Org 7.7 (latest git version.)
>
> What version of Emacs and Org are you using?

Hmm, i'm using Org bundled with Emacs.

emacs-version: GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7600) of
2011-06-28 on 3249CTO
org-version: 7.4  (BTW, why such big difference from org git...)


-William

Re: org-toggle-inline-images bug

[Bastien]

Hi William,

William Xu <william.xwl@gmail.com> writes:

>> What version of Emacs and Org are you using?
>
> Hmm, i'm using Org bundled with Emacs.

I guess it has been fixed in the meantime.  If you have the 
opportunity to use Org from git, please do so:

  http://orgmode.org/index.html#sec-3-2

> emacs-version: GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7600) of
> 2011-06-28 on 3249CTO
> org-version: 7.4  (BTW, why such big difference from org git...)

Because I did not take the time to merge Org into Emacs before 
the 7.7 release of Org.  Merges should happen more often in the 
future.

-- 
 Bastien