From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [RFC] Simplify attributes syntax Date: Wed, 13 Mar 2013 16:28:00 +0100 Message-ID: <87wqtbe2v3.fsf@gmail.com> References: <87ppz9zar8.fsf@gmail.com> <87txofptxi.fsf@sbs.ch> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:43996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFnbB-0005IM-N5 for emacs-orgmode@gnu.org; Wed, 13 Mar 2013 11:28:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFnb9-0004Ec-L0 for emacs-orgmode@gnu.org; Wed, 13 Mar 2013 11:28:13 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:52486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFnb9-0004EU-Bw for emacs-orgmode@gnu.org; Wed, 13 Mar 2013 11:28:11 -0400 Received: by mail-wi0-f181.google.com with SMTP id hm6so886705wib.8 for ; Wed, 13 Mar 2013 08:28:10 -0700 (PDT) In-Reply-To: <87txofptxi.fsf@sbs.ch> (Christian Egli's message of "Wed, 13 Mar 2013 09:47:53 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Christian Egli Cc: emacs-orgmode@gnu.org Hello, Christian Egli writes: > Nicolas Goaziou writes: > >> The following patch simplifies syntax for attributes. >> >> From the developer POV, each non-nil value is now read as a string by >> `org-export-read-attribute'. > > I looked at your patch but I'm not sure of the implications. In > particular I'm unsure if I need to change anything in ox-taskjuggler.el. > > Is line 402 in org-taskjuggler--build-attributes maybe suspicious? > > (intern (upcase (format ":%s" attribute))) > No it isn't. The change only affects attributes obtained with `org-export-read-attribute' function, which isn't used in ox-taskjuggler.el. Regards, -- Nicolas Goaziou