From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Christian Egli <christian.egli@sbs.ch>
Cc: emacs-orgmode@gnu.org
Subject: Re: [RFC] Simplify attributes syntax
Date: Wed, 13 Mar 2013 16:28:00 +0100 [thread overview]
Message-ID: <87wqtbe2v3.fsf@gmail.com> (raw)
In-Reply-To: <87txofptxi.fsf@sbs.ch> (Christian Egli's message of "Wed, 13 Mar 2013 09:47:53 +0100")
Hello,
Christian Egli <christian.egli@sbs.ch> writes:
> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>
>> The following patch simplifies syntax for attributes.
>>
>> From the developer POV, each non-nil value is now read as a string by
>> `org-export-read-attribute'.
>
> I looked at your patch but I'm not sure of the implications. In
> particular I'm unsure if I need to change anything in ox-taskjuggler.el.
>
> Is line 402 in org-taskjuggler--build-attributes maybe suspicious?
>
> (intern (upcase (format ":%s" attribute)))
>
No it isn't. The change only affects attributes obtained with
`org-export-read-attribute' function, which isn't used in
ox-taskjuggler.el.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2013-03-13 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 0:18 [RFC] Simplify attributes syntax Nicolas Goaziou
2013-03-09 0:44 ` Thomas S. Dye
2013-03-09 13:55 ` Bastien
2013-03-09 14:45 ` Nicolas Goaziou
2013-03-09 19:55 ` Aaron Ecay
2013-03-09 21:19 ` Nicolas Goaziou
2013-03-11 7:40 ` Nicolas Goaziou
2013-03-13 8:47 ` Christian Egli
2013-03-13 15:28 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqtbe2v3.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=christian.egli@sbs.ch \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).