From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: use save-window-excursion in agenda archiving? Date: Fri, 05 Jul 2013 17:37:35 +0800 Message-ID: <87wqp5pctc.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uv2SL-0007Sm-3f for emacs-orgmode@gnu.org; Fri, 05 Jul 2013 05:37:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uv2SK-0004wx-Bq for emacs-orgmode@gnu.org; Fri, 05 Jul 2013 05:37:33 -0400 Received: from plane.gmane.org ([80.91.229.3]:51975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uv2SK-0004wW-5n for emacs-orgmode@gnu.org; Fri, 05 Jul 2013 05:37:32 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Uv2SE-00011a-DA for emacs-orgmode@gnu.org; Fri, 05 Jul 2013 11:37:26 +0200 Received: from 114.250.104.60 ([114.250.104.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jul 2013 11:37:26 +0200 Received: from eric by 114.250.104.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jul 2013 11:37:26 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org I don't know if this is a new development, but archiving items from the agenda causes the buffer to jump so the archived line is at the top of the window. This is pretty distracting, and makes archiving multiple items kind of annoying. I believe switching the `save-excursion' call at line 8382 of org-agenda.el (inside `org-agenda-archive-with') to a `save-window-excursion' instead solves the problem. Might this break anything I haven't thought of? If not I can provide a patch. Eric