From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <schulte.eric@gmail.com>
Subject: Re: patch for ob-sql and postgresql for supporting :colnames
Date: Wed, 08 Jan 2014 09:58:08 -0700
Message-ID: <87wqiaqulb.fsf@gmail.com>
References: <87bnzm4ol5.fsf@snow.nl>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1W0wUB-0004XJ-4X
	for emacs-orgmode@gnu.org; Wed, 08 Jan 2014 12:00:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1W0wU6-0000Hl-Fn
	for emacs-orgmode@gnu.org; Wed, 08 Jan 2014 12:00:07 -0500
Received: from mail-pb0-x22c.google.com ([2607:f8b0:400e:c01::22c]:47310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1W0wU6-0000GL-8a
	for emacs-orgmode@gnu.org; Wed, 08 Jan 2014 12:00:02 -0500
Received: by mail-pb0-f44.google.com with SMTP id rq2so1813761pbb.31
	for <emacs-orgmode@gnu.org>; Wed, 08 Jan 2014 09:00:01 -0800 (PST)
In-Reply-To: <87bnzm4ol5.fsf@snow.nl> (Joost Helberg's message of "Wed, 08 Jan
	2014 13:58:46 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Joost Helberg <joost@snow.nl>
Cc: Org-Mode <emacs-orgmode@gnu.org>

Applied, thanks.

Joost Helberg <joost@snow.nl> writes:

> hi,
>
> the :colnames header argument is not honoured for postgresql. Hence the
> following patch for ob-sql.el. The command-line tool psql supports the
> option -t for not displaying column-names. The default behavious is not
> changed with this patch.
>
> 126,127c126
> <                                 "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\"  -f %s -o %s %s"
> <                                   (if colnames-p "" "-t")
> ---
>>                                 "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\"  -f %s -o %s %s"
>
> Can anyone suggest to me why this should not be in ob-sql.el? It is
> already implemented for the mysql engine (via -N).
>
> regards,
>
> Joost

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D