From: Eric Schulte <schulte.eric@gmail.com>
To: Joost Helberg <joost@snow.nl>
Cc: Org-Mode <emacs-orgmode@gnu.org>
Subject: Re: patch for ob-sql and postgresql for supporting :colnames
Date: Wed, 08 Jan 2014 09:58:08 -0700 [thread overview]
Message-ID: <87wqiaqulb.fsf@gmail.com> (raw)
In-Reply-To: <87bnzm4ol5.fsf@snow.nl> (Joost Helberg's message of "Wed, 08 Jan 2014 13:58:46 +0100")
Applied, thanks.
Joost Helberg <joost@snow.nl> writes:
> hi,
>
> the :colnames header argument is not honoured for postgresql. Hence the
> following patch for ob-sql.el. The command-line tool psql supports the
> option -t for not displaying column-names. The default behavious is not
> changed with this patch.
>
> 126,127c126
> < "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\" -f %s -o %s %s"
> < (if colnames-p "" "-t")
> ---
>> "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\" -f %s -o %s %s"
>
> Can anyone suggest to me why this should not be in ob-sql.el? It is
> already implemented for the mysql engine (via -N).
>
> regards,
>
> Joost
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D
next prev parent reply other threads:[~2014-01-08 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 12:58 patch for ob-sql and postgresql for supporting :colnames Joost Helberg
2014-01-08 16:58 ` Eric Schulte [this message]
2014-02-03 13:11 ` Joost Helberg
2014-02-03 14:54 ` Bastien
2014-02-04 10:04 ` Joost Helberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqiaqulb.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=joost@snow.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).