From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasmus <rasmus@gmx.us>
Subject: Re: interaction between org-latex-custom-lang-environments and name
 when exporting to latex
Date: Mon, 30 Nov 2015 14:11:44 +0100
Message-ID: <87wpsz4oof.fsf@gmx.us>
References: <m2ziyertfg.fsf@polytechnique.org>
	<m2d1v59kaq.fsf@charm-ecran.irisa.fr> <877fld3qcr.fsf@gmx.us>
	<m28u5p3r5p.fsf@charm-ecran.irisa.fr> <8737vw1u13.fsf@gmx.us>
	<m2poyz3jnz.fsf@charm-ecran.irisa.fr> <87vb8rbkum.fsf@gmx.us>
	<m2a8q2wlts.fsf@polytechnique.org> <87610qbdvx.fsf@gmx.us>
	<m2egfbif18.fsf@wifi-eduroam-161006.inria.fr> <87h9k740gy.fsf@gmx.us>
	<m2bnabznxh.fsf@polytechnique.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49908)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rasmus@gmx.us>) id 1a3OFD-0006pR-NZ
	for emacs-orgmode@gnu.org; Mon, 30 Nov 2015 08:11:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rasmus@gmx.us>) id 1a3OF9-0004gg-FO
	for emacs-orgmode@gnu.org; Mon, 30 Nov 2015 08:11:51 -0500
Received: from mout.gmx.net ([212.227.17.22]:51734)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rasmus@gmx.us>) id 1a3OF9-0004gU-5e
	for emacs-orgmode@gnu.org; Mon, 30 Nov 2015 08:11:47 -0500
In-Reply-To: <m2bnabznxh.fsf@polytechnique.org> (Alan Schmitt's message of
	"Mon, 30 Nov 2015 13:12:10 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: alan.schmitt@polytechnique.org
Cc: emacs-orgmode@gnu.org

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

>> It should be a defcustom.  Feel free to fix it, preferably in a separate
>> patch.
>
> Here is a patch to do so.
>
> From b94b5ba0bdb619cb9047efb19432216812eaf6a2 Mon Sep 17 00:00:00 2001
> From: Alan Schmitt <alan.schmitt@polytechnique.org>
> Date: Mon, 30 Nov 2015 13:07:56 +0100
> Subject: [PATCH] ox-latex: Make org-latex-custom-lang-environments a defcustom
>
> * ox-latex.el (org-latex-custom-lang-environments): Change from defvar
>   into a defcustom.
> ---
>  lisp/ox-latex.el | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index eaad29f..407df6b 100644
> --- a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -1021,7 +1021,7 @@ block-specific options, you may use the following syntax:
>  	   (string :tag "Minted option name ")
>  	   (string :tag "Minted option value"))))
>  
> -(defvar org-latex-custom-lang-environments nil
> +(defcustom org-latex-custom-lang-environments nil
>    "Alist mapping languages to language-specific LaTeX environments.
>  
>  It is used during export of src blocks by the listings and minted
> @@ -1062,7 +1062,14 @@ will produce
>    \\end{minted}
>    \\caption{<caption>}
>    \\label{<label>}
> -  \\end{listing}")
> +  \\end{listing}"
> +  :group 'org-export-latex
> +  :type '(repeat
> +	  (list
> +	   (symbol :tag "Language name                    ")
> +	   (string :tag "Environment name or format string")))

I don't know if the strings have to the same width, but I assume you
tested it before hand.  For me at least this is the only way to evaluate
Custom changes.

To me it looks fine.  Thanks a lot, Alan!

Rasmus

-- 
When in doubt, do it!