From: Kyle Meyer <kyle@kyleam.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas
Date: Thu, 10 Mar 2016 11:00:07 -0500 [thread overview]
Message-ID: <87wppauxvc.fsf@kyleam.com> (raw)
In-Reply-To: <87twkelm5u.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Thu, 10 Mar 2016 10:25:33 +0100")
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>> Fix the quote style when in the "C-c '" key-binding that is printed in the
>> echo via the substitute-command-keys function. In emacs 25.x, a straight
>> quote is rendered as a right-curly quote by default.
>
> Shouldn't this be handled by `substitute-command-keys' already? The fix
> looks like a hack.
message will still try to apply its quoting changes to the output of
substitute-command-keys.
While it does look like a hack, I think it's the easiest way to fix it
and consistent with how it's been handled on Emacs's side (see, e.g.,
Emacs's 6cd2629 and Org's d77a52a).
--
Kyle
next prev parent reply other threads:[~2016-03-10 16:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 16:18 [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas Kaushal Modi
2016-03-10 9:25 ` Nicolas Goaziou
2016-03-10 15:33 ` Kaushal Modi
2016-03-10 16:05 ` Paul Eggert
2016-03-10 16:00 ` Kyle Meyer [this message]
2016-03-10 16:38 ` Kyle Meyer
2016-03-10 16:41 ` Kaushal Modi
2016-03-10 17:47 ` Kaushal Modi
2016-03-10 18:24 ` Kaushal Modi
2016-03-11 1:39 ` Paul Eggert
2016-03-11 3:22 ` Kaushal Modi
2016-03-11 4:30 ` Kyle Meyer
2016-03-11 4:55 ` Kaushal Modi
2016-03-11 5:12 ` Kyle Meyer
2016-03-11 17:44 ` Kaushal Modi
2016-03-11 18:47 ` Kyle Meyer
2016-03-11 19:16 ` Kyle Meyer
2016-03-12 4:01 ` Kyle Meyer
2016-03-12 4:57 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wppauxvc.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).