From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Tag visibility fixup after setting them Date: Thu, 29 Dec 2016 01:39:30 +0100 Message-ID: <87wpejo9fh.fsf@nicolasgoaziou.fr> References: <87shp9r7ds.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMOkn-0007Pn-V4 for emacs-orgmode@gnu.org; Wed, 28 Dec 2016 19:39:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMOkn-0000n2-9Y for emacs-orgmode@gnu.org; Wed, 28 Dec 2016 19:39:34 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:57782) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cMOkn-0000lZ-3c for emacs-orgmode@gnu.org; Wed, 28 Dec 2016 19:39:33 -0500 In-Reply-To: <87shp9r7ds.fsf@gmail.com> (Alexey Lebedeff's message of "Tue, 27 Dec 2016 13:30:55 +0300") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Alexey Lebedeff Cc: Orgmode Mailing List Hello, Alexey Lebedeff writes: > This fixes bug where you sometimes can't immediately see tags that were > just set. And to reveal them you need to go through global visibility > cycle. Thank you for the patch, and the test. > +(defun org-insert-visible-text (&rest args) > + "Inserts arguments at point and makes them visible in outline. > + > +When text is being inserted on the invisible region boundary, it > +can be inadvertently sucked into invisibility." > + (let* ((before-point (point))) > + (apply #'insert args) > + (outline-flag-region before-point (point) nil))) I don't think, for the time being, it deserves a dedicated function. I suggest to integrate it in `org-set-tags' instead. Could you send an updated patch ? Regards, -- Nicolas Goaziou