From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: More clocktable breakage Date: Fri, 28 Apr 2017 20:56:47 +0200 Message-ID: <87wpa4fjio.fsf@Rainer.invalid> References: <877f39nr05.fsf@Rainer.invalid> <87d1d0p2qx.fsf@nicolasgoaziou.fr> <87tw5bumck.fsf@Rainer.invalid> <87shkt4tuf.fsf@Rainer.invalid> <8737ct1xyr.fsf@nicolasgoaziou.fr> <87fugt4npu.fsf@Rainer.invalid> <87pofxzctf.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4B4f-0003jp-48 for emacs-orgmode@gnu.org; Fri, 28 Apr 2017 14:57:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4B4b-0006Rj-6T for emacs-orgmode@gnu.org; Fri, 28 Apr 2017 14:57:01 -0400 Received: from [195.159.176.226] (port=46541 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d4B4a-0006PT-Vg for emacs-orgmode@gnu.org; Fri, 28 Apr 2017 14:56:57 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d4B4S-0001c4-AL for emacs-orgmode@gnu.org; Fri, 28 Apr 2017 20:56:48 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Another idea is to add an optional argument to `org-at-timestamp-p' to > allow "sloppy" matching (or strict matching, it doesn't really matter) > and skip checks when it is required. So all functions requiring this > predicate can make use of it, as long as they call it properly. > > WDYT? That's what I've been asking the whole time: when you changed that predicate, you've basically cut off some of its consumers. It looks like bad factoring to me to then splitting the same predicate based on some argument. I'd rather pull out the old sloppy matching into a new predicate for instance. >> Also, again, I think that function is buggy even without these issues as >> the only code I can find in org-element-context that deals with >> timestamps is conditional on being on a planning line and if that's true >> we should never get there. > > I don't think there is a bug there. Do you have an ECM? I don't use planning, so no. But it seems to me that the only way for org-element-context to deliver a 'timestamp is when pos is on a planning line (that may be wrong, I just don't see where else a 'timestamp would be returned). In that case we've already left the cond, so testing for it doesn't do anything useful. I'm also not really sure why the existing exceptions from the "true" timestamp (planning, property and clock-log) are any different than "dynamic block" would be (with the appropriate change of the doc string of course).y Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves