emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "N. Raghavendra" <nyraghu27132@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-html.el: Fix display of language indicators for source blocks
Date: Wed, 07 Jun 2017 01:38:26 +0530	[thread overview]
Message-ID: <87wp8oyj45.fsf@gmail.com> (raw)
In-Reply-To: <8760g9ywga.fsf@hri.res.in> (N. Raghavendra's message of "Tue, 06 Jun 2017 20:50:21 +0530")

At 2017-06-06T20:50:21+05:30, N. Raghavendra wrote:

> CSS rules like
>
> pre.src-awk:before { content: 'Awk'; }
>
> in `org-html-style-default' don't work in the current Org version,
> because the class attribute has been moved from the `pre' element to a
> `code' child of that element.

It appears that this change was introduced in commit
d5bbf365533ba45d72ebed8121c7612c860ea944.  It also introduced the
insertion of the attribute "data-editor-type" in the HTML export, when

  1. `org-html-klipsify-src' is true, and

  2. an HTML source block is being exported.

Now, "data-editor-type" is not a valid attribute with respect to the
XHTML1 Strict DTD (or any other W3C X/HTML DTD).  Therefore, when 1 and
2 are true, this attribute renders the exported HTML files invalid with
respect to the DTDs in `org-html-doctype-alist'.  I think this would
count as a drawback to those who care about HTML validation, especially
since ox-html indicates its concern for validation through
`org-html-validation-link', etc.

I don't know what is the best way to deal with this problem.  One
possibility is to put a warning in the documentation of
`org-html-klipsify-src' that setting it to true would lead to invalid
HTML exports when the Org file contains an HTML source block.

Cheers,
Raghu.

-- 
N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

  reply	other threads:[~2017-06-06 20:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 15:20 [PATCH] ox-html.el: Fix display of language indicators for source blocks N. Raghavendra
2017-06-06 20:08 ` N. Raghavendra [this message]
2017-06-08 18:57 ` N. Raghavendra
2017-06-08 19:24   ` Nicolas Goaziou
2017-06-08 19:42     ` N. Raghavendra
2017-06-12 16:45       ` Matt Price
2017-06-14 17:32         ` N. Raghavendra
2017-09-19  0:54           ` N. Raghavendra
2017-09-19 17:18             ` N. Raghavendra
2017-09-19 20:02               ` Nicolas Goaziou
2017-06-08 20:15     ` Matt Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp8oyj45.fsf@gmail.com \
    --to=nyraghu27132@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).