From mboxrd@z Thu Jan 1 00:00:00 1970 From: cesar mena Subject: Re: please read: bug when marking tasks done Date: Tue, 08 Jan 2019 15:07:23 -0500 Message-ID: <87woneykuc.fsf@gnu.org> References: <87d0paprs6.fsf@gnu.org> <87wonhcpnj.fsf@nicolasgoaziou.fr> <871s5o8pgf.fsf@gnu.org> <87muobcur7.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:52610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggxew-0007oq-SX for emacs-orgmode@gnu.org; Tue, 08 Jan 2019 15:07:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggxev-0006n3-Hk for emacs-orgmode@gnu.org; Tue, 08 Jan 2019 15:07:34 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60317) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggxet-0006m8-Ik for emacs-orgmode@gnu.org; Tue, 08 Jan 2019 15:07:32 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CB03026EC2 for ; Tue, 8 Jan 2019 15:07:25 -0500 (EST) Received: from [127.0.1.1] (pool-71-126-174-77.washdc.fios.verizon.net [71.126.174.77]) by mail.messagingengine.com (Postfix) with ESMTPA id C57A3E4662 for ; Tue, 8 Jan 2019 15:07:24 -0500 (EST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode hello nicolas, Nicolas Goaziou writes: > Hello, > > cesar mena writes: > >> as per the documentation for "org-auto-repeat-maybe" only the base date >> of repeating deadline/scheduled time stamps should change. AFAICT the >> patch changes every occurrence of an inactive repeating timestamp that is >> not a comment. > > The base date of a time stamp is the part before the repeater. IOW, > every time stamp with a repeater has a base date, therefore > `org-auto-repeat-maybe' changes them all. I see no problem with the > docstring. the _base date_ is not the pertinent part; the _deadline/scheduled_ aspect is. moreover this should only happen on the headline. from the docstring: |----------- org-auto-repeat-maybe -------------------------------- | Check if the *current headline* contains a repeated time-stamp. | | If yes, set TODO state back to what it was and change the base date | of repeating *deadline/scheduled time stamps to new date* | | ... |----------------------------------------------------------------- thus we should not programmatically modify an arbitrary date in a document just because it has a repeater. specially not one buried 300 lines deep in a :LOGBOOK: drawer. commit af81211fdc contradicts the established documentation. see bernt hansen's email in this thread for another unintended consequence. he can't mark a task that is no longer scheduled as DONE because there is an inactive timestamp in a :LOGBOOK: entry. > I don't think we agree about the immutable part. see below for clarification. > At least, the user who reported the bug solved in > af81211fdc01b64449179bcdb77fb1c8ecb3fb94 didn't agree. but the solution overreaches. again, only repeating deadline/scheduled time stamps should change if they are in the current headline. > Inactive time stamps are not immutable. apologies if i wasn't clear. what should be immutable is a logged, state-change entry. an existing entry should not change because one marks a task as DONE. regards, -cm