From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Subject: Re: orgalist-mode: wrong indentation in message mode after recent
 change in emacs
Date: Tue, 23 Apr 2019 11:53:02 +0100
Message-ID: <87wojldmcx.fsf@tcd.ie>
References: <87k1gdptsn.fsf@len.workgroup> <87ef6l9x13.fsf@tcd.ie>
	<87a7ghw2tc.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
In-Reply-To: <87a7ghw2tc.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Tue, 23 Apr 2019 10:20:15 +0200")
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
List-Id: emacs-orgmode.gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> The first is whether orgalist-mode couldn't use a custom
>> indent-line-function instead of advising what may or may not be set to
>> indent-relative by the user.
>
> I don't know how that would work in practice.

Me neither.

> But a minor mode taking control over `indent-line-function' sounds
> wrong.

Well, orgalist already "takes control" over indent-line-function and
indent-according-to-mode via advice, and the latter advice seems to
assume that indent-line-function is set to the default indent-relative
or indent-relative-first-indent-point.

>> The second is why advice--buffer-local does what it does.  Stefan, why
>> does it behave differently depending on local-variable-p?  Why can't it
>> simply call make-local-variable before returning the symbol-value?
>>
>> The third is why indent-according-to-mode hard-codes the check for
>> indent-relative and indent-relative-first-indent-point.  Wouldn't it be
>> nice if this check instead looked up some variable akin to
>> electric-indent-functions-without-reindent, that can be more easily
>> customised?
>
> So what is the current status of this? Do I still need to add
> a workaround around a workaround around a genuine Emacs bug? :)

Yes. :) I think the patch I proposed in my previous email should be
applied to orgalist, as a first step at the very least.

Thanks,

-- 
Basil