From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: A few changes to test in master Date: Fri, 07 Feb 2020 17:08:30 +0100 Message-ID: <87wo8ycrcx.fsf@bzg.fr> References: <87wo9750jl.fsf@gnu.org> <87a75yrdye.fsf@gmail.com> <87sgjpd059.fsf@bzg.fr> <87y2tequa6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:49728) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j06BF-0005Us-PC for emacs-orgmode@gnu.org; Fri, 07 Feb 2020 11:08:34 -0500 In-Reply-To: <87y2tequa6.fsf@gmail.com> (Jack Kamm's message of "Fri, 07 Feb 2020 07:41:37 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Jack Kamm Cc: emacs-orgmode@gnu.org Hi Jack, Jack Kamm writes: > FWIW, I wouldn't mind if this were a global minor mode, I intend to > activate it globally with `org-table-header-line-p'. Well, it only makes sense in org buffers, so activating it through this variable is okay IMO. > Since updating and testing for a few minutes, I haven't noticed this > issue anymore. However, I have noticed a new bug, where the header line > randomly gets "stuck" on some row of the table, so even when I scroll > and that row is no longer on top of the buffer, that row is still > replaced by the header line. Yes, fixed now. >> M-x customize-face RET org-table-header RET > > Thanks. The default face looks great on light-themed backgrounds like > leuven, but is hard to read on some dark-themed backgrounds like > tsdh-dark or zenburn, due to their light text. While this could be left > to the user or individual themes to fix, it'd be nice if it worked out > of the box for the common dark themes. Maybe the simplest solution would > be to set both the background and foreground colors in the default > face? Sure - would you like to suggest a patch for this? -- Bastien