From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jack Kamm <jackkamm@gmail.com>
Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell
Date: Wed, 19 Feb 2020 07:51:24 -0800
Message-ID: <87wo8ik22r.fsf@gmail.com>
References: <877e0kjbqq.fsf@gmail.com> <874kvnako5.fsf@gmail.com>
 <871rqrak5y.fsf@gmail.com>
 <CAL1eYu+2MhYJq3fOduU1miefTiXtV+v0vtsJ=BobastLNnzyNg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:34497)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <jackkamm@gmail.com>) id 1j4ReM-0005df-NC
 for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 10:52:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <jackkamm@gmail.com>) id 1j4ReL-0003FS-Q7
 for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 10:52:34 -0500
Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:52089)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <jackkamm@gmail.com>) id 1j4ReL-0003Ez-Ki
 for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 10:52:33 -0500
Received: by mail-pj1-x1041.google.com with SMTP id fa20so246478pjb.1
 for <emacs-orgmode@gnu.org>; Wed, 19 Feb 2020 07:52:33 -0800 (PST)
In-Reply-To: <CAL1eYu+2MhYJq3fOduU1miefTiXtV+v0vtsJ=BobastLNnzyNg@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: "numbchild@gmail.com" <numbchild@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hi stardiviner,

"numbchild@gmail.com" <numbchild@gmail.com> writes:

> Yes, Jack, as Bastien said, you can format my commit, because my home
> network is broken, I'm using Mobile Phone's 4G network to get online. Can't
> get update immediately.

OK, I've edited the commit message of your patch, and I also fixed the
compilation warning by updating the signature of "(declare-function
py-shell)".

Commit has now been pushed to master :)

> And thanks for tips about `python-mode' is deprecated. I didn't know that.
> I will migrate to `python.el'.

Since python.el is built-in to Emacs, I think that things should
continue to work for python-mode.el users, even if we entirely switch
over to only using python.el.

The only thing I'm not sure about, is whether the equivalent of
"python-shell-send-region" in python-mode.el will work with shells
started by python.el. If not, this could probably be addressed with a
patch to python-mode.el.

You could test this by explicitly setting `org-babel-python-mode' to
`python' (it is probably set to `python-mode' on your system, which is
the default when python-mode.el is detected).

I'll add a TODO for myself to explicitly mark python-mode-related
variables as deprecated. I'm also planning a major update to the Worg
documentation of ob-python when 9.4 comes out, and will mention the
deprecation there as well.