From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adam Porter <adam@alphapapa.net>
Subject: Re: org-pop-mode
Date: Wed, 18 Mar 2020 14:15:47 -0500
Message-ID: <87wo7hzd7g.fsf@alphapapa.net>
References: <7d38c66d-6ea5-ff8f-ee39-142c8dbdcd18@kli.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:55774)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1jEeAW-0005PO-3s
 for emacs-orgmode@gnu.org; Wed, 18 Mar 2020 15:15:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1jEeAU-0006lw-Vy
 for emacs-orgmode@gnu.org; Wed, 18 Mar 2020 15:15:56 -0400
Received: from ciao.gmane.io ([159.69.161.202]:55576)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1jEeAU-0006fy-Q5
 for emacs-orgmode@gnu.org; Wed, 18 Mar 2020 15:15:54 -0400
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1jEeAS-000MPZ-LS
 for emacs-orgmode@gnu.org; Wed, 18 Mar 2020 20:15:52 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: emacs-orgmode@gnu.org

"Mark E. Shoulson" <mark@shoulson.com> writes:

> This is something I've wanted for years in org-mode, but which in some
> ways could actually be _offensive_ to its ideals.  If you're an
> outline purist, look away.
>
> ...
>
> So, I present a pre-alpha version,
> https://gist.github.com/clsn/09ac4b098b6ad7366bb5e0bc88882d5f of
> org-pop-mode.  To "pop" back up, create a headline at the level you're
> popping back to, and give it a tag of "contd", and the headline text
> should not be something important.  Instructions and explanations are
> in the comments of the file (the part about installing from MELPA is a
> lie, though).
>
> Any feedback?

Hi Mark,

Indeed, this is something that is frequently asked about.  I probably
wouldn't use it myself, but it looks like you've done a good job on it.
Here is some feedback:

1.  I'd suggest a more descriptive name, especially if you plan to
publish it to MELPA.  org-pop doesn't seem to convey anything about what
it does.  :)

2.  In the code, I saw you comment about cl-flet, and I see you using
fset and unwind-protect in the org-pop-with-continuations macro.
Instead, use cl-letf with symbol-function, like:

  (cl-letf* (((symbol-function 'foo)
              #'my-foo)
             ((symbol-function 'bar)
              (lambda ()
                ...)))
    BODY)

See also Nic Ferrier's package, noflet.