From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WBnVIk2eyl6nCgAA0tVLHw (envelope-from ) for ; Sun, 24 May 2020 16:18:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yMDVHk2eyl6aUwAAB5/wlQ (envelope-from ) for ; Sun, 24 May 2020 16:18:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 961E79400C3 for ; Sun, 24 May 2020 16:18:20 +0000 (UTC) Received: from localhost ([::1]:52796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jctKN-0004ks-D7 for larch@yhetil.org; Sun, 24 May 2020 12:18:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jctJr-0004kT-S4 for emacs-orgmode@gnu.org; Sun, 24 May 2020 12:17:47 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:64287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jctJp-00025P-ME; Sun, 24 May 2020 12:17:47 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 9F92CD8A8C; Sun, 24 May 2020 12:17:42 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=Lu2g3mHrTszGS08Hbtk0sQt6rN8=; b=u+VK7E 80K1CKlozMoTLMBLmGbr7jMitq42cETiGYBy3AlmeD6QcIP2rMdQ0HNzAKbmwki5 cBAr7RaIIyDi5hGiyJZ6WHtDLHigWqbx8ADmj9Tjz8s4cLBt4IwKdzF8ikYhVnq9 /zsCJ4WyV6tAFsMW4ffGTbHKbjdYM7LhZv+vw= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 95AC1D8A8B; Sun, 24 May 2020 12:17:42 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=N/QnML25QEIHBaOqOc8CrOqzrm1sjC5IgsSpdjvSWz0=; b=YxgxhcUEC8w4jS0CsY0SV4uN/Z9GBKiDfxzFT5CO9miJzFLU2kw5e8Yt5hXFeng/wwLuso168x/v5B7ibVWuVLHhQ2Dk1Di/6LTSKX48yajnwiD5MhXovp6Fn5RFEu3FojNAHFcbX50MTte3n2HR4tzOCcBKi+2eIvlEXmfgCaM= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id BF239D8A8A; Sun, 24 May 2020 12:17:39 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Bastien , Kevin Foley Subject: Re: [PATCH] Fix `org-babel-detangle' handling of false positives In-Reply-To: <87wo51moo1.fsf@gnu.org> References: <8736buek6n.fsf@gnu.org> <87h7zzdkqo.fsf@gnu.org> <87y2pk7zhn.fsf@gnu.org> <87wo51moo1.fsf@gnu.org> Date: Sun, 24 May 2020 16:17:37 +0000 Message-ID: <87wo515mu6.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 16BAA642-9DDA-11EA-8E6B-8D86F504CC47-24757444!pb-smtp21.pobox.com Received-SPF: pass client-ip=173.228.157.53; envelope-from=kyle@kyleam.com; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/24 12:17:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=u+VK7E 8; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=YxgxhcUE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.29 X-TUID: I/qfG3u3q3av Hi Kevin and Bastien, This change (010d1e3b6) needs a follow-up patch. Running the tests now leaves the working tree dirty: diff --git a/testing/examples/babel.org b/testing/examples/babel.org index b0942800a..e95a65b85 100644 --- a/testing/examples/babel.org +++ b/testing/examples/babel.org @@ -499,5 +499,5 @@ ** linked content to detangle :ID: 73115FB0-6565-442B-BB95-50195A499EF4 :END: #+begin_src emacs-lisp :tangle yes :comments link - ;; detangle + ;; detangle changes #+end_src Kevin, could you look into updating the test to avoid changing the repo state? Thanks.