From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eK55HhT50l8+KwAA0tVLHw (envelope-from ) for ; Fri, 11 Dec 2020 04:44:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OP5AGhT50l+pawAAB5/wlQ (envelope-from ) for ; Fri, 11 Dec 2020 04:44:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7A86940480 for ; Fri, 11 Dec 2020 04:44:03 +0000 (UTC) Received: from localhost ([::1]:58462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knaHi-0000zH-MY for larch@yhetil.org; Thu, 10 Dec 2020 23:44:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kna4Y-0005Mk-1I for emacs-orgmode@gnu.org; Thu, 10 Dec 2020 23:30:27 -0500 Received: from out0.migadu.com ([94.23.1.103]:65266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kna4V-0006wp-2k for emacs-orgmode@gnu.org; Thu, 10 Dec 2020 23:30:25 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1607661020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=Z3qizBSQgJWQlkgac3vD8UWlbImR91ImoDwewuTRyz0=; b=oiCbXwW07+yHYdSQzbT7bNmI6jEr21X397Abjg5ROs4sgHTRdgvpEsOvkipTOfwvQCwAhe H9/j8U7uyKH0BiqkuaXtNadJQlliXXEjJspBBSXAUrarCs3bagI/JyA9wcnCNUgHAaQF1P TieHE5EuxBZXuRLsCyj3fMG+sr3tKBaWtQsiQ/2AcPKs92aG0CMQwvRhyIfaN5Lh/qwpUy l0ywvc4pj5BcPNes/MfI9/tPwacu/cWMxTt790HxXgsZVUCvt0FCZwMdDi9tuTEWYGUJNf CIlBPg5RhCKmxdXVyn1feYN/6ZrHjOv9+UgY+2ZSos3bA/Ay5fixpRcilTCDbQ== From: Kyle Meyer To: Jan =?utf-8?Q?L=C3=BCbke?= Subject: Re: org-mac-link patch In-Reply-To: Message-ID: <87wnxpklr9.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Auth-User: kyle@kyleam.com Date: Fri, 11 Dec 2020 04:30:20 GMT Received-SPF: pass client-ip=94.23.1.103; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.50 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=oiCbXwW0; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: B7A86940480 X-Spam-Score: -2.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: OG4taN/Hcfer Jan L=C3=BCbke writes: > Good morning, > > this is my first time submitting a patch, here. Thank you! > I hope I did everything right. If I made a mistake, please let me > know. If you have any questions, feel free to ask. The patch format looks good. I have only minor/cosmetic comments. > Not sure if this is even an official bug, yet. However here is a fix > for a strange behaviour: Links to mail.app don=E2=80=99t open any more af= ter > upgrading to macOS 11. Sounds like a bug. I don't run macOS, so I'd be very grateful if another macOS/mail.app user could confirm that your patch works on their end. > From: raumi75 <@raumi75> Is it okay if I set this to the sender address of the main message? > Date: Wed, 9 Dec 2020 09:31:01 +0100 > Subject: [PATCH] contrib module org-mac-link.el/open links from Mail.app:= fix > compatibility issue with macOS 11 Big Sur. It'd be nice to shorten a bit. Perhaps contrib/org-mac-link.el: fix Mail.app link compatibility with macOS 11 > * org-mac-link.el (org-mac-message-open): replaced angular brackets with = encoded version (< to %3C and > to %3E) so macOS 11 Big Sur can open the me= ssage in mail.app Looks good. Please wrap the commit message lines, something like the slightly edited * org-mac-link.el (org-mac-message-open): Replace angular brackets with encoded version (< to %3C and > to %3E) so macOS 11 Big Sur can open the message in mail.app. > TINYCHANGE macOS 11 does not open the mail link with angular brackets any= more. This fix is backwards compatible. I have tested it on macOS 10.15.= 7. Great, thanks for considering and checking the backwards compatibility. That was going to be my main question. > --- > contrib/lisp/org-mac-link.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el > index d16190e5a..e692acb3e 100644 > --- a/contrib/lisp/org-mac-link.el > +++ b/contrib/lisp/org-mac-link.el > @@ -912,7 +912,7 @@ selected items in DEVONthink Pro Office and make link= (s) out of it/them." > "Visit the message with MESSAGE-ID. > This will use the command `open' with the message URL." > (start-process (concat "open message:" message-id) nil > - "open" (concat "message://<" (substring message-id 2) "= >"))) > + "open" (concat "message://%3C" (substring message-id 2)= "%3E"))) Looks as advertised :) Again, it'd be good to get another macOS user to confirm, but if not, I'll go ahead and apply this patch in a few days. If my suggested commit message edits above look okay to you, there's no need to resend. I can amend when applying. Thanks again. >=20=20 > (defun org-as-get-selected-mail () > "AppleScript to create links to selected messages in Mail.app." > --=20 > 2.29.2