From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wOXLC9Hj819qEAAA0tVLHw (envelope-from ) for ; Tue, 05 Jan 2021 03:58:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uDGgB9Hj81+uFQAAB5/wlQ (envelope-from ) for ; Tue, 05 Jan 2021 03:58:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 645EC9403C5 for ; Tue, 5 Jan 2021 03:58:08 +0000 (UTC) Received: from localhost ([::1]:54446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwdTz-0003EA-8N for larch@yhetil.org; Mon, 04 Jan 2021 22:58:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwdSx-0003E3-F9 for emacs-orgmode@gnu.org; Mon, 04 Jan 2021 22:57:03 -0500 Received: from out1.migadu.com ([2001:41d0:2:863f::]:2440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwdSq-0008GJ-Cw for emacs-orgmode@gnu.org; Mon, 04 Jan 2021 22:57:03 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1609819011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RWY56hbrb9UEVq4kXNpIPJvqv2X7gzkC/wFszXLsxH8=; b=mpiYcaCncr3JjHSdLbipFAJ3NoJuiG/V4wfRHzrHd9iw23AsVO+xJSU9UOuLYWiJ3UCehe CiebNy+k9ax2o6DdtwcKIIqkardNT+ZJ81N0egE7wRvIviSUH1LQCmKGVsWKpP7Chk5+mK nAKzKfT0a9uo7qStoy8gLTDP14Y5lJEb4ZURb8BEpzLbfvXtGxhcyQ7eb6oi5w2F0sR7Dp vdH6pnkx2b7LONe8EKE1wBHVon/pBF5GwwTsxBnKLvJpWb01xodvpYNPVXjYrfh3VLpd3I 5elJIWBlVlH8KLmveGC9vHFtpUdBf59CaoB3aqYow1gf/1Mlj9McnH/v7XtjoA== From: Kyle Meyer To: David Florness Subject: Re: [PATCH v2] org-contacts.el: Only use org-id-store-link if org-id is loaded In-Reply-To: <87eej0dqqx.fsf@florness.com> References: <874kjxpqht.fsf@florness.com> <87eej0dqqx.fsf@florness.com> Message-ID: <87wnwsyr26.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Date: Tue, 05 Jan 2021 03:56:51 GMT Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=kyle@kyleam.com; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Stefan Monnier Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=kyleam.com header.s=key1 header.b=mpiYcaCn; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 645EC9403C5 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5w7H6xu8Jsrv David Florness writes: > Fixes bug introduced in 6b83c6e4e that made org-contacts-anniversaries > error if org-id was not loaded. > --- > v1 -> v2: Stefan Monnier made a good suggestion to use bound-and-true-p > instead here: https://lists.gnu.org/r/emacs-devel/2021-01/msg00257.html stardiviner already applied/pushed v1 to master, so please reposition the patch on top of the previous commit (e6e1c0811). Also, while we're less strict about the commit message format for contrib/ files, it'd still be good to follow the changelog entry convention. Thanks.