From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gkwhHWUHA2DFbQAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 15:33:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IKNHGGUHA2BjYQAAbx9fmQ (envelope-from ) for ; Sat, 16 Jan 2021 15:33:57 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C48199402A7 for ; Sat, 16 Jan 2021 15:33:56 +0000 (UTC) Received: from localhost ([::1]:40050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0naN-00036X-Mi for larch@yhetil.org; Sat, 16 Jan 2021 10:33:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0nYx-0002Go-Mc for emacs-orgmode@gnu.org; Sat, 16 Jan 2021 10:32:27 -0500 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:37916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0nYv-0005qC-RB for emacs-orgmode@gnu.org; Sat, 16 Jan 2021 10:32:27 -0500 Received: by mail-lf1-x136.google.com with SMTP id h205so17632763lfd.5 for ; Sat, 16 Jan 2021 07:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=11XgEQdSBwDhet1cbqWbysBE3AYvEhLxWheQOW8m6tM=; b=NIc9G1zHhYpb9Hrc/OMcRbbnDzeDPpuVRQcxPMU5eX3OcjXhYbeTMbyVv4ODzBWMBY 1Xx6mHex0CD52YJINBvvcwt6rxNLKsQVD6WwnGof8AoxLm/yRl8T449XZOvtcE8izoyV eOt4+ebz6a1XDG9Qx00/Bvmxq5qr4yUCjjr9skXG2kzFa3qkKLzNHY8BhOHZwACYrq/4 P5bbgWlKpYxdvNso5dfx8wJGxgv0k6VPXEGL9vUuGEgl44b6s8HJXRTVsba1YGEJtWcu 6GJ+le6enX5zJ4uC5qSoyIDDNWBRXEnhhYgRW7aEgOtfnw/e2gyMJqJCXtw8aFcs+ybc 7g2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=11XgEQdSBwDhet1cbqWbysBE3AYvEhLxWheQOW8m6tM=; b=j0V971VV+u1pt3rrYbePkjCdkAYxjDAJgnYWrbnTByjhZC6prnePvwmU2tcYvIO3LY /bfxecWG67pVjHOF6F7cLNfb2N0lENmBvYF16gUA5RwgUkzDWP4M1pkDss5qy3nLxOid p52AD6Am8GKZg1HOcNLiFYczJizxnU6ZolapObgwp2ychAt3P20olDbXhSCpbc+ydiJr kQnc9cARFjijunuUGPHPWVzCTfmrh6gyKAPjxPMqa/T8EYiodO3+EApFU/rZ8Wg5TYO+ /q18AtZ8BQNRb22ByPB6Hk18pHTVlikpPkxIiJApywXgLwaEc+XG3tks4RP+z1JMMnKN /HPg== X-Gm-Message-State: AOAM530FcGwF3tcLfSs2q4viF0N0ARbhgsCWwEhM5BC7EjBjOUavMBco PkgXS7OtznsxHokDzjTsEo0RGuz4X3g= X-Google-Smtp-Source: ABdhPJxYYfRO8CCHXFtVFOYugiiLf1Zl1g681Eq/XeM29gSy6RxmJMvxTb40fzJ6kX/p+rW65WcK1g== X-Received: by 2002:a19:770c:: with SMTP id s12mr7849334lfc.367.1610811143007; Sat, 16 Jan 2021 07:32:23 -0800 (PST) Received: from fnox (h-160-111.A147.priv.bahnhof.se. [85.24.160.111]) by smtp.gmail.com with ESMTPSA id i25sm1298030lfl.157.2021.01.16.07.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jan 2021 07:32:21 -0800 (PST) References: <87o8hzv1e8.fsf@gmail.com> <87lfd0v7e6.fsf@gmail.com> User-agent: mu4e 1.4.13; emacs 27.1 From: John Herrlin To: ian martins Subject: Re: [PATCH] ob-java, a proposal on import improvement In-reply-to: Message-ID: <87wnwcq4n0.fsf@gmail.com> Date: Sat, 16 Jan 2021 16:32:20 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=jherrlin@gmail.com; helo=mail-lf1-x136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=NIc9G1zH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: C48199402A7 X-Spam-Score: -3.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ije6pWIP5nlq --=-=-= Content-Type: text/plain Sorry for latency, 9to5 been killing it. Thx for the feedback, make sense! Here is a new patch with the improvements. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-ob-java-Include-static-imports-in-regex.patch >From 680e04217c8e4c536875379cac01edccd694c4cb Mon Sep 17 00:00:00 2001 From: John Herrlin Date: Sun, 10 Jan 2021 21:47:26 +0100 Subject: [PATCH] ob-java: Include static imports in regex * lisp/ob-java.el (org-babel-java--imports-re): Include static imports in Java import regex. TINYCHANGE --- lisp/ob-java.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/ob-java.el b/lisp/ob-java.el index f70a50192..c9698bd72 100644 --- a/lisp/ob-java.el +++ b/lisp/ob-java.el @@ -87,6 +87,7 @@ like javac -verbose." (0+ space) ?\; line-end) "Regexp for the package statement.") (defconst org-babel-java--imports-re (rx line-start (0+ space) "import" + (opt (1+ space) "static") (1+ space) (group (1+ (in alnum ?_ ?.))) ; capture the fully qualified class name (0+ space) ?\; line-end) "Regexp for import statements.") -- 2.30.0 --=-=-= Content-Type: text/plain ian martins writes: > John, would you mind if I go ahead and make the change I mentioned and > push it with you as the author? > > On Tue, Jan 12, 2021 at 7:00 AM ian martins wrote: >> >> On Sun, Jan 10, 2021 at 3:55 PM John Herrlin wrote: >> > ian martins writes: >> > > I think the problem was that I was missing static >> > > imports, which you fixed in the first chunk of your patch. I don't >> > > think the rest of the change is necessary. Could you revert the other >> > > chunks and re-test? >> > >> > Thats looks correct! Thanks! >> > >> > Here is a patch with the regexp fix. >> >> That's great. One small change, though. This only allows for a single >> space between "import" and "static" so if someone were to put in two >> it wouldn't work. I actually did the same thing in an earlier version >> and it caused a problem. Since then I went to =(1+ space)= >> everywhere. Could you also move the part that you're adding down to >> the next line. It's not that the line is too long, but it keeps it to >> one thing per line. >> >> The commit message is fine, but the first line shouldn't end in a period. >> >> ref: https://orgmode.org/worg/org-contribute.html#commit-messages --=-=-=--