From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yjKQMgyZYmCrjgAAgWs5BA (envelope-from ) for ; Tue, 30 Mar 2021 05:20:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SDt+KwyZYmDeBAAAB5/wlQ (envelope-from ) for ; Tue, 30 Mar 2021 03:20:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DF1910FD7 for ; Tue, 30 Mar 2021 05:20:44 +0200 (CEST) Received: from localhost ([::1]:52836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lR4vr-0007Qx-AB for larch@yhetil.org; Mon, 29 Mar 2021 23:20:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lR4vL-0007Qn-Gc for emacs-orgmode@gnu.org; Mon, 29 Mar 2021 23:20:11 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:42770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lR4vI-0003NI-Ku for emacs-orgmode@gnu.org; Mon, 29 Mar 2021 23:20:11 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1617074404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/lg5pa/6+gwEiZ/ynNzNlYSvdJhUzKEfcpz+asN8Ups=; b=sfvDSs21Lm9ZqrY1AIsZmZszpKzzxQfC8zFXezPuqbb9HJNNV1GNbnIEYuixt2Xq84uQ/4 Av3D4KJYfgEytKgFLkz21vzFIBBa3OhZn+FZl+I2uVBXBeoxgJ56tl7R2uyIzCAP0Cs+4+ GmW23z4voAE/2UFW+EzBJBeVVqBSMN2qxQ/PXpjesZbL89sgADMH/cslvmoSnEOx+++ZpA wPjkOHpCCINLi/Beijpune2xTN7EpAhvAtZ47I59HI35mvOz7yWWWhagHlL9OQaINXPKKK l1vKSmAZj2tPO0zKN8IYSqzkqLRPUPsBi20U6uxTtEniVXga/EJdifplFyczuA== From: Kyle Meyer To: Renato Ferreira Subject: Re: [PATCH] org-agenda.el: Rename org-agenda-format-item parameters In-Reply-To: <87tuozgh75.fsf@gmail.com> References: <87tuozgh75.fsf@gmail.com> Date: Mon, 29 Mar 2021 23:20:02 -0400 Message-ID: <87wntp2uql.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=kyle@kyleam.com; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617074444; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/lg5pa/6+gwEiZ/ynNzNlYSvdJhUzKEfcpz+asN8Ups=; b=Jnz0MRrk3dN/JNMkt8LQesoMO9PT+6+RDrEA1y5cebERPwHzJR6CtumDelUneXEakNeOqL wxi9LlyP1OUCEQkoOn3Oauezvb3gqAhPtYKRh5OVceRG1V9goG03zEKw692MhVzElxO/Fu 0ZiuIM6gmS90PI/AhJniw7CusA4MPCEWDi9bNgpWX8aPUVc8P3iyg1SXw8/sDwwqmXCogt Y+9WWRqgXal/d/7NeYsBDtYMeSBukvN4135Bfra+vefEisbEgDB1XRXHs25yR2GWZR4FdD IV3KdofzAlKe2MLqgyzrmSeO/zCSUQP0ObKt5SQYWEzhIY1l4EmRuvsk5ZGbTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617074444; a=rsa-sha256; cv=none; b=fGTkLQv8jefneuh8oei5f1CFQavVdh06SMhTycuy5iCKdxjphXcizfAngFhR0rgPiUqQ8+ q+KCa2rlftkRgrE/v8+fMQUbWYb1r0QAPG1CKxiXV9hpqnCN1FEMk8T5JGCf0iYpZG1Ga7 ++3NOTYMvS6HlkRUVvOafEioXBoft23TZbM5EPwzG2iRN9rVY69xSJIhlsAsPlr1ZTqLh0 SlaFEe70m/DpxDudsbIVdmUJOijX9B59jglVYlHMN6TyLDp2FfvYg3ZKP+EBw7JCAh9gyI NWpAxE+d07PGawAwolO2ekRZ3Uo+tk7AtrclYauRKp+OpTfB7mvONcIPj/eQBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=sfvDSs21; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=sfvDSs21; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3DF1910FD7 X-Spam-Score: -1.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9clf3Ih44fsV Renato Ferreira writes: > * org-agenda.el (org-agenda-format-item): Rename parameters so they > don't clash with dynamic variables used by > `org-prefix-format-compiled'. Thanks. Presumably you arrived at this patch because you hit into a particular issue (related the lexical binding conversion in 129c33ddd). Could you provide a reproducer (or at least a description) for that problem? That'd be useful for reviewing this patch, as well as assessing if the conversion has other similar issues.