From: Nicolas Goaziou <email@example.com>
To: Stefan Monnier <firstname.lastname@example.org>
Subject: Re: More use of lexical-binding in ox.el
Date: Tue, 27 Apr 2021 23:12:46 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <firstname.lastname@example.org> (Stefan Monnier's message of "Mon, 19 Apr 2021 23:37:50 -0400")
Stefan Monnier <email@example.com> writes:
> Here's another patch to remove some more use of the old dynamically
> scoped dialect of ELisp.
> * lisp/ox.el: Fix various uses of the non-lexical-binding ELisp dialect.
> (org-export--get-global-options, org-export-insert-default-template):
> Use lexical-binding.
> (org-export--generate-copy-script): Return a closure rather than
> list starting with `lambda`.
> (org-export-async-start): Turn it into a function (there seems to be
> no reason this was a macro). Use `write-region` rather than
> `with-temp-file`. Always use `utf-8-emacs-unix` coding system since
> it's more efficient and is guaranteed to handle all chars.
> Use lexical-binding in the temp file as well.
> Actually set `debug-on-error` if `org-export-async-debug` says so.
> (org-export-to-buffer, org-export-to-file): Pass a closure rather than
> list starting with `lambda` to `org-export-async-start`.
It looks great but it introduces a test failure, however.
`org-export-expand-include-keyword' is called from within
At the very beginning of `org-export-expand-include-keyword', there is
Before the patch, it returned the source file name. After the patch it
Actually I'm a bit surprised it used to work, since we're evaluating
this from a new buffer, not an existing one. But hey, it worked!
Do you know what could cause this?
next prev parent reply other threads:[~2021-04-27 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 3:37 More use of lexical-binding in ox.el Stefan Monnier
2021-04-27 21:12 ` Nicolas Goaziou [this message]
2021-04-27 22:51 ` Stefan Monnier
2021-04-28 8:45 ` Nicolas Goaziou
2021-04-28 14:15 ` Stefan Monnier
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).