From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iFcoL8jYn2D4PAAAgWs5BA (envelope-from ) for ; Sat, 15 May 2021 16:20:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KE/HKsjYn2AXbQAAB5/wlQ (envelope-from ) for ; Sat, 15 May 2021 14:20:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3953827E7E for ; Sat, 15 May 2021 16:20:56 +0200 (CEST) Received: from localhost ([::1]:33886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhv9z-0005lb-1Y for larch@yhetil.org; Sat, 15 May 2021 10:20:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhv9C-0005l3-FV for emacs-orgmode@gnu.org; Sat, 15 May 2021 10:20:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44588) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhv9B-0007VU-9i; Sat, 15 May 2021 10:20:05 -0400 Received: from [78.194.183.21] (port=50392 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhv99-0004iy-Bd; Sat, 15 May 2021 10:20:05 -0400 Received: by guerry (Postfix, from userid 1000) id 287F71A60E5E; Sat, 15 May 2021 16:19:56 +0200 (CEST) From: Bastien To: Tim Frana Subject: Re: [PATCH] org-agenda.el: Fix clocking issues regex In-Reply-To: (Tim Frana's message of "Sat, 15 May 2021 16:14:33 +0200") Organization: GNU References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 15 May 2021 16:19:56 +0200 Message-ID: <87wns0axkj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621088456; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=lkU7SEA2YGMEC/bdB2FNnwzVmLzHdg9m0ZPV553InBw=; b=D4cpyGzVfR0eD6tOBtm0/iq+2+jLX0xaFa7og2CiTfiBcSNclrhaV0/MV9/qBTMKnvUHGs o5TEKbuMUXEw7KT+sMevZX3xUaevxeXrTsSAeoK0px8S2Z+E8wg8hVQO5tSzG2Tlz3JjYl RUMWfhH7cNvL4Vpk+lDSdVci4L0Ls1vSPeKGD6qfds2ckrqCgxgxh0gz39ZEQnrGXU+NR/ K9v+3Lt8PipOD3pTkbrzGWzbX0iTNGwXqh9ztnWAmffMV1sRotu8Nhs5Mh9+XA3P05jSZy sPsuGaB9lJAn8sZYlBbh+AdT8gb7LZIg/fshCGN5V8SNoBFKdng7jrlBkiuJKg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621088456; a=rsa-sha256; cv=none; b=QYzWpAIbwE1xrCUKrW74wOV0cI20Yj55UE+CI4DArDMG24e5qjEdGCZegl68w2IG1EH7OX Mr0vXJgxLqcQUSUSvzAbj31wfdaozcsxZV8K30R68MdniTbp3E7oQIO4WZDcbg2ExA5oC1 ScTulv1wZj1jhKqYk/As/5J4ohdO2n9jFOmmCPUWrxUpkIXuunYRa0sej0xqNbBAco4JCL DSQQiIsBBPfK/4h4ZZLlcGtX8lXlFHBUjoNQNQY0AOJHljkM53PtMVhmso3uoXwZI8m6vM XOA5n8JI/6eW0SNu8IWrXO6VI2vY4k0Ebbwg7vglWMGJiDYHyMF01TD9pglJHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3953827E7E X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: fFL3yydYzrA9 Hi Tim, Tim Frana writes: > The method org-agenda-show-clocking-issues has a faulty regex, which > leads to false-positive > clocking issues: " Clocked: +(-\\|\\([0-9]+:[0-9]+\\))" > > There is no outer group to limit the OR-expression \\|, so the right > half will match timestamps with > a closing parenthesis without any "Clocked" in front of it. > > I added a non-capturing group in the attached patch: " Clocked: > +(\\(?:-\\|\\([0-9]+:[0-9]+\\)\\))". Applied, thanks a lot for the careful analysis and the patch with the proper commit message. Best, -- Bastien