emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Tim Frana <tfr@mailbox.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda.el: Fix clocking issues regex
Date: Sat, 15 May 2021 16:19:56 +0200	[thread overview]
Message-ID: <87wns0axkj.fsf@gnu.org> (raw)
In-Reply-To: <ee0f9461-026e-2d5b-005e-0a1c1aa5a727@mailbox.org> (Tim Frana's message of "Sat, 15 May 2021 16:14:33 +0200")

Hi Tim,

Tim Frana <tfr@mailbox.org> writes:

> The method org-agenda-show-clocking-issues has a faulty regex, which
> leads to false-positive
> clocking issues: " Clocked: +(-\\|\\([0-9]+:[0-9]+\\))"
>
> There is no outer group to limit the OR-expression \\|, so the right
> half will match timestamps with
> a closing parenthesis without any "Clocked" in front of it.
>
> I added a non-capturing group in the attached patch: " Clocked:
> +(\\(?:-\\|\\([0-9]+:[0-9]+\\)\\))".

Applied, thanks a lot for the careful analysis and the patch with the
proper commit message.

Best,

-- 
 Bastien


      reply	other threads:[~2021-05-15 14:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-15 14:14 [PATCH] org-agenda.el: Fix clocking issues regex Tim Frana
2021-05-15 14:19 ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wns0axkj.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=tfr@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).