From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6Ko/Ho9LXGHhBAAAgWs5BA (envelope-from ) for ; Tue, 05 Oct 2021 14:56:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OIHDGY9LXGGFDgAAbx9fmQ (envelope-from ) for ; Tue, 05 Oct 2021 12:56:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BDD4DAD61 for ; Tue, 5 Oct 2021 14:56:46 +0200 (CEST) Received: from localhost ([::1]:56884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXjzx-0002t6-Ab for larch@yhetil.org; Tue, 05 Oct 2021 08:56:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXjyM-0002re-RY for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 08:55:06 -0400 Received: from ciao.gmane.io ([116.202.254.214]:48870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXjyL-0004X9-AI for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 08:55:06 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mXjyI-0001YN-5t for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 14:55:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Adam Porter Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Tue, 05 Oct 2021 07:52:48 -0500 Message-ID: <87wnmrvdjz.fsf@alphapapa.net> References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633438606; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zNzYgK5cguFrsay5xzw+f4oEyb9XnbHeYOEt9cflXLA=; b=H3qhkhp7Lj6yRSOwi53EmKpgrIdNgtxkNhckXgLFhWC6D6K8tdXCwU19UvFdU7s9OSR37o HJeafbemD2+Nj3A8mcrd8UXS0lQRycab/liSM5nNOlY2EKTyOyqDh8ENzYQMU/SLoWbPZL 1VKvaO+frMNZ3PVr/zepteLfc3rBS/sMpsRmIqYem7dYB4rKuJlg4zKOAydGGACrS0EVdN u5WYblNer9aogcxW5aEpwY3/k1+56Ne3TtOedD9D/9D/hVHDx11Yg9VYFrnIGJLIMhLVgv lZmRS1Fl7oLHtlHjX5ngB+UgK/Mp0xtmgzVpAWAdhKnIZGIWwCYTcav+Zfap8A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633438606; a=rsa-sha256; cv=none; b=u8JB5Wg1np/oRJL6ei3IXX4FWilJUq97PNvzV8Yml9BKqGKw8N7sGbJ1Uh11C6GW2LByKg E9vUbDLKQR6kLSp4TpowVbiB2bD2mKNk9exsimSeBl2S9cfhop/xBn9G7WZjOKl7VuT4VH 4PtPY/Vtg2Z7HbaI63whzvc1I1JaQRe06QCf09voNiS5KL87e4XX68i8472iJuqvBsuZCM YyU5079uXrEUyPTjqeM4oKc5KLlxG7vdybbv4RX54DZslwAAPTPQQt3mdcsBv3XnFWW1c+ Rxp4u0uk3gCFy7LDoCcxdaLf8cApTVEhM4PURGk8L31EGF/uAaTKHfMZFbZmXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BDD4DAD61 X-Spam-Score: -1.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5UULXgEYHqrN Hi Ihor, > See the attached fix. The fix looks reasonable, though I fail to > understand why org-no-popup was even used in org-goto-location. We kind > of want a popup there. git blame did not reveal anything useful either. > > Adam, can you test the fix in different scenarios first? I do not use > org-goto interface, so I only did a light testing. A quick test seems to indicate that it works again. Please note that I only recently started using org-goto myself, so I can't claim to know all the ways in which it ought to be tested. :) Thanks.