From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CDjlIOVNQGN82wAAbAwnHQ (envelope-from ) for ; Fri, 07 Oct 2022 18:03:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kCYAIeVNQGMccgEAauVa8A (envelope-from ) for ; Fri, 07 Oct 2022 18:03:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E8B73A909 for ; Fri, 7 Oct 2022 18:03:49 +0200 (CEST) Received: from localhost ([::1]:57320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogppE-00078t-AN for larch@yhetil.org; Fri, 07 Oct 2022 12:03:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogpIt-0006Fn-Sa for emacs-orgmode@gnu.org; Fri, 07 Oct 2022 11:30:24 -0400 Received: from out0.migadu.com ([94.23.1.103]:38218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogpIr-0007dD-7l for emacs-orgmode@gnu.org; Fri, 07 Oct 2022 11:30:23 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1665156617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A1IXmLf0Zfrw8QK404qZsd7lXAfBq4XBI5DKdgv03AE=; b=NSWpvB0A1nJ9NQVH8SZbX6eRkJv4OoAqE3QoXONaaxoCYcIo4cenpa3TzHbzHT5ii+TGGU uYrHIlD4XjSxnxy2wSIICeFWE3hvOR2bc5dq1VqbXOa0nHvQLSFSpiwrnKTiuryDlzqctc kn9GmhgTxmqjDPp+x7m4zxjGfcuieDpdaIrW+ma7MF76tFnzpVofbg/8X0OymNW5dom0+b YfiHo5eZspVgfozc3cBJ3N5hbpdWz4zb53QD1nzHrtfMZ85GY2S7wNqqBAhWtHlYhl+YqJ bw7f8lzB3jQgkxX0X7UOxiNsnuLp7Xo6w/w7p+IBiP9KNBQjDeLN+Q32Hbupxw== From: Kyle Meyer To: Ihor Radchenko , Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] Re: 98e168b48 Add compatibility wrapper for string-clean-whitespace (Emacs 26 compatibility) [9.6-pre (release_9.5.5-920-g057193 @ /home/yantar92/.emacs.d/straight/build/org/)] In-Reply-To: References: <8735c01aho.fsf@localhost> Date: Fri, 07 Oct 2022 11:30:15 -0400 Message-ID: <87wn9baby0.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=94.23.1.103; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665158629; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=A1IXmLf0Zfrw8QK404qZsd7lXAfBq4XBI5DKdgv03AE=; b=Nn2VofP33VD46F6zUzhjd0bAPc/bQkom8k0Yts/LesscxnKez1TCRI+9ZqVgvRsOknDk+F +4e05bxHiQiakOpHN75iuSA6KSnrYFxqVuw1Y0G0liXHBwnRt1l0C6SeUXhKktLNjWud6a jI1Mz2wIvEB0FHQErOKeEHm2fqNWhnIfWhpxhLpprPsL1pN+EAKqHuKG/wJ9xHOeSpvfl0 fn4rttH74q75Lt5HWEQqElyuf75kcld9rdN9KaUAX3JdXj2IrfWQF3lAmERsDQozYhjYqC KMKr5Bxzcn9pIjNvjYoy713Xb0CzqoMMPzaRrWoFBg9UxXcmF1/lMedzErMbbw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665158629; a=rsa-sha256; cv=none; b=mjpMsyjEooj0y64U3NLzMMkaEE0+Xu2l6nbjSZzZXSzDDdu0YrOKkF8uFAGB3M3LK611li 2gAL7jBXTSCFdsf1HfTUWgOYkDTvQhLU6IcFkdtpOsxoYKeB/ebWNEtFyTdW3qStIOfTX3 71KA45vKEAHXIGIFCV8AJK7NbC16Y7NGcsLdEzGncA5bxUekzvA06i88UUbNwOPSW8cqcu MYh8fzolN/qN9vQs7ysXnY59Jph+vqxe9aWNtBEUzhqkcQiDyG1Ztt/ef5RYwMG/2sL9Hn UG9I1q1khPLup4HZPU3qHZ04DITMhTZbo1YO2Zm1UJ2Pz/OAfADCa5buYSDJVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=NSWpvB0A; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.47 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=NSWpvB0A; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2E8B73A909 X-Spam-Score: -3.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1S3zfDnGBnHc Max Nikulin writes: > On 07/10/2022 12:14, Ihor Radchenko wrote: >> >> The following commit adds `string-trim', which is not yet available in >> Emacs 26. > > It is available in Emacs-26, however (require 'subr-x) should be added. > > There is `org-trim' and despite it is less generic, likely it can be > used if subr-x is avoided for some reason. Ihor, sorry for overlooking that. As Max mentions, indeed string-trim used to be in subr-x. It's been available since Emacs 24 and was relocated with Emacs 28's a4ececf004e (Move string-trim functions to subr.el, 2021-03-24). I won't be at my computer much today or tomorrow, but, when I get a chance, I'll plan to add something like (eval-when-compile (require 'subr-x)) ; Emacs < 28 And of course please feel free to beat me to it and fix it however you see fit. Thanks.