Clock dates - org-shiftdown not working

Clock dates - org-shiftdown not working

[Tebe Nigrelli]

[-- Attachment #1: Type: text/plain, Size: 4323 bytes --]

On a clean configuration, applying org-shiftdown does not work for the
following date format, written as a clock. I want to reduce the number of
hours
on the second date from "03:" to "02:". This is what happens if I apply
org-shiftdown:
- On the minutes :: from ":XX" minutes, there is a decrease by the usual
"default" amount (5 minutes), but after reaching "00", the count decreases
to 55 without decreasing the number of hours to "02"
- On the hours   :: "03" does not roll back to "02", but can roll up to "04"
or "05"
- Minutes / Days / Years all work as intended

This bug appears in a scratch buffer in org-mode.
Manually editing the date and applying C-c C-c reverts the "02:" date to
"03:"

Instructions to reproduce the bug:
Try doing org-shiftdown on the minutes "05" or the hours "03".
Result:
CLOCK: [2023-03-25 Sat 21:40]--[2023-03-26 Sun 03:05] =>  4:25

Emacs : GNU Emacs 28.2 (build 2, x86_64-apple-darwin22.1.0, NS
 appkit-2299.00 Version 13.0.1 (Build 22A400)) of 2023-02-05 Package:
 Org mode version 9.5.5 (release_9.5.5 @
 /usr/local/Cellar/emacs-plus@28/28.2/share/emacs/28.2/lisp/org/)

current state:
==============
(setq
 org-link-elisp-confirm-function 'yes-or-no-p
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
 org-cycle-show-empty-lines
 org-optimize-window-after-visibility-change)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-show-all append local]
  5]
#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-babel-show-result-all
   append local]
  5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-confirm-shell-link-function 'yes-or-no-p
 outline-isearch-open-invisible-function 'outline-isearch-open-invisible
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
    org-src-mode-configure-edit-buffer)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-speed-command-hook '(org-speed-command-activate
 org-babel-speed-command-activate)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
     org-babel-header-arg-expand)
 org-link-shell-confirm-function 'yes-or-no-p
 org-babel-pre-tangle-hook '(save-buffer)
 org-agenda-loop-over-headlines-in-active-region nil
 org-occur-hook '(org-first-headline-recenter)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link)
      ("id" :follow org-id-open)
      ("eww" :follow org-eww-open :store org-eww-store-link)
      ("rmail" :follow org-rmail-open :store
org-rmail-store-link)
      ("mhe" :follow org-mhe-open :store org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link
:export org-irc-export)
      ("info" :follow org-info-open :export org-info-export
:store org-info-store-link)
      ("gnus" :follow org-gnus-open :store
org-gnus-store-link)
      ("docview" :follow org-docview-open :export
org-docview-export :store org-docview-store-link)
      ("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
      ("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store
org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link)
      ("doi" :follow org-link-doi-open :export
org-link-doi-export)
      ("file+sys") ("file+emacs")
      ("shell" :follow org-link--open-shell)
      ("news" :follow
#[514 "\301\300\302Q\"\207"
 ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("mailto" :follow
#[514 "\301\300\302Q\"\207"
 ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("https" :follow
#[514 "\301\300\302Q\"\207"
 ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("http" :follow
#[514 "\301\300\302Q\"\207"
 ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("ftp" :follow
#[514 "\301\300\302Q\"\207" ["ftp" browse-url ":"]
 6 "\n\n(fn URL ARG)"]
)
      ("help" :follow org-link--open-help :store
org-link--store-help)
      ("file" :complete org-link-complete-file)
      ("elisp" :follow org-link--open-elisp))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 )

[-- Attachment #2: Type: text/html, Size: 5754 bytes --]

[BUG] Shifting timestamp hours around daylight transition (was: Clock dates - org-shiftdown not working)

[Ihor Radchenko]

Tebe Nigrelli <nigrellitebe@gmail.com> writes:

> On a clean configuration, applying org-shiftdown does not work for the
> following date format, written as a clock. I want to reduce the number of
> hours
> on the second date from "03:" to "02:". This is what happens if I apply
> org-shiftdown:
>
> Instructions to reproduce the bug:
> Try doing org-shiftdown on the minutes "05" or the hours "03".
> Result:
> CLOCK: [2023-03-25 Sat 21:40]--[2023-03-26 Sun 03:05] =>  4:25

At least in some parts of Europe, the time from 2023-03-26 2:00 to
2023:03-26 2:59 does not exist. It is the hour-forward daylight
transition.

So, when Org is trying to change the data to 2023-03-26 2:05, Emacs date
library refuses and instead sets the closes valid time.

I am not sure would be the best course of action here.
1. We can jump over the invalid hours in the direction requested by user
2. We can throw an error, making the user aware about the daylight
   thing.

I am more in favour of (2) because things like this are easy to overlook.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>