From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IGZxK6fZX2TugwAASxT56A (envelope-from ) for ; Sat, 13 May 2023 20:40:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GMuXKqfZX2QB9gAAG6o9tA (envelope-from ) for ; Sat, 13 May 2023 20:40:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B995FBEE for ; Sat, 13 May 2023 20:40:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxu9i-0005JE-IR; Sat, 13 May 2023 14:39:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxu9e-0005J3-V4 for emacs-orgmode@gnu.org; Sat, 13 May 2023 14:39:43 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxu9c-0006LM-Vn for emacs-orgmode@gnu.org; Sat, 13 May 2023 14:39:42 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9301E240104 for ; Sat, 13 May 2023 20:39:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684003177; bh=FzLu0U2dGcyRaXtzpIPJO0Kd2puwy3r3Yr2CwTrd5as=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=SsHklduWR1XyEQrkrxRP8CF/+a3qRbaoA4bndYhsuWtg5r4o8QXviVaZuJc0dbp2i 0D/fqq5h0I1njJ49Q09+wMQ6b67k9xrS/a7Upl1G56m4AwQdYxtNJyBm/IxSltR4Oe MWnndHfpBgd42DOTszq3lfFdNlyThvqdH0bpXLCEpWENqjPvE/tzm3TooXdtCP0mlB YA3nUlqCslXwwiEgBbbQVJH04J/Ov3vMF8fvb25nR1Tt2yl0Pt9URIAkkqvkJo0V+v XAUi+09SeWPCSSU5irp+lxKiZ9+bvj5vaz1WxolXM/rAHw1wissfsXor1GQTWtXBmO t+s2TdY4/lghA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QJZDT1Z47z9rxD; Sat, 13 May 2023 20:39:37 +0200 (CEST) From: Ihor Radchenko To: "Christopher M. Miles" Cc: Org-mode Subject: Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` In-Reply-To: <645fc094.170a0220.4d545.38e1@mx.google.com> References: <878rds1xta.fsf@localhost> <87a5y8iiak.fsf@localhost> <645fc094.170a0220.4d545.38e1@mx.google.com> Date: Sat, 13 May 2023 18:43:00 +0000 Message-ID: <87wn1cgjij.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684003239; a=rsa-sha256; cv=none; b=ckdNUZAO5AP7LZzbHuzsTD5+eoD6IKubmG27d7uFq5tsOZ2+CBN0oZ/OG749+gbPVoW5aB DYuTtK3e3dn02lJWSCFI60nuTPiOtWrSB7aszEKAMaa1Vw/gSwbNPfrp1YZ7jnDltsWCZ/ 1TatHGhHYHNoSDO4HU5glKpCyMLIt5yUSueMkjUSCQNAFxALQFiThnGWaleemjZIYmjPXy wm/tuUuEnWfe/HrkEqELfNl6f+kQM0sRrwxg03WWnkjKv+NXNJ30XS3nPs7ngNtxvm346Y uNt1bGREAqRfkRCj8AmfRiFwDdh6tST/Eh6KEwkLS9pyCakib9BIVXwxH/HXZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SsHklduW; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684003239; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jE+alBcqWM3INu0tamR/fh5i0tzQIXIcREo4ZWU/2o4=; b=n9ajfY4+lZRTYnsM/8bd3DSkv46EaFORG/iINjGXbPrKPvRs1gPDpDdNn89hyaP3g+R4D3 zg4w7h4NjQ2ESowVYguk8lHD/CfaED8nX3K6nUUI3Q9Qxb9iPvLWMgnkNObWjWGeoePgRN I/6HjoYZUSgmI2kP/XFIbjj20a9KZ/LqKgXLl7ASgfBCDfXyS9RCkvBhW0mpac0BedofBw T0l2Q6q2xrEceSH4Da/XUKPd0TV3azS0eeFg0Uu8fCpUSXnUn4Xa7yJKHAg8EO8Zfp98yY NNGW1QjuJVehTf6BGIzW+EDsvMvJtObxvelSq2vYBsCZ82PRk2wBszghqFjJbg== X-Migadu-Spam-Score: -6.69 X-Spam-Score: -6.69 X-Migadu-Queue-Id: 3B995FBEE X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SsHklduW; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: FLjlEEms/Ggl "Christopher M. Miles" writes: >> It would be great if you can come up with a patch. >> 1. Keeping tags with explicitly assigned key binding indeed makes sense >> 2. If we limit the number of displayed tags (on top of explicitly >> assigned), it should be a defcustom. > > Here is the patch. > - (setq tbl fulltable char ?a cnt 0) > + (setq tbl (seq-filter 'cdr fulltable) char ?a cnt 0) Thanks, but it will make the tag selection useless for people who did not customize explicit tag bindings. You should instead only filter when the number of tags exceeds some customized value. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at