From: Ihor Radchenko <yantar92@posteo.net>
To: Liu Hui <liuhui1610@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix docstring of `org-at-timestamp-p'
Date: Thu, 24 Aug 2023 07:20:57 +0000 [thread overview]
Message-ID: <87wmxk7vom.fsf@localhost> (raw)
In-Reply-To: <CAOQTW-Pr-_WX-HPvSfVycND_frRnmN5t-wAf5J0rGz-goWmtLQ@mail.gmail.com>
Liu Hui <liuhui1610@gmail.com> writes:
> I find that the doc string of `org-at-timestamp-p' about match groups
> is not consistent with the behavior. The doc string says
>
> ...
> but for timestamps like <2023-08-23 Wed>, (when (org-at-timestamp-p)
> (match-string 2)) will return the year 2023 instead of the month. This
> patch corrects the group numbers.
Thanks!
Applied, onto bugfix, adding slightly more details to the commit message.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=973e50c83
The docstring did not correspond to the actual match data since group
info was added there. So, no actual regression in the code occurred.
Pure bug in the docstring. That's why bugfix.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-08-24 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 6:31 [PATCH] Fix docstring of `org-at-timestamp-p' Liu Hui
2023-08-24 7:20 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmxk7vom.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=liuhui1610@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).