From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id mPetEjTQL2ZTaAAAe85BDQ:P1 (envelope-from ) for ; Mon, 29 Apr 2024 18:52:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id mPetEjTQL2ZTaAAAe85BDQ (envelope-from ) for ; Mon, 29 Apr 2024 18:52:04 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=GIVhZ9C8; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714409524; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vmbLEDFrzuPlXKz6IPru5pMaxt7F95hnSH6RRXoRHoE=; b=pzrKXLRuJZsUFcDrgcVQBthVEKMYvh0SGLB+502UL6NDm8hAmmo1QZTImftWilaI1CtZHH Beu8OVotIjywPZoiD2cvyZti1SFaoEak1IlPijy0I9aE8XAOMqfVRbc4KZutaqMrKKgLhG NKWYN2xd6+aGc5de/NHfMnRCyu4Y40kRg35HwwsOtEXibn+wEFcQYnXz2LdGPYpziHD5er C1Z64Uo2Mv03AQdbpurxJkZ0qk4rdnbRGBkbrQm4v1Ijf4jEaV+jOyrY8Xg8SrjhPzi5QK lI+/mAaLRx3g3TaVcb9DTvZRw98M8+535WkBSR4qH3S3hxZpiTqWGbCN9C+C9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714409524; a=rsa-sha256; cv=none; b=GM5rT2oFYhh7OYkK+aMtAlBNrTEoDfWKB7vclH2j0T8F6qLYYi7uZHQv890RmTAqZVUNGl rFGbCLOITDHcZ26O0t83CzM02cCPUUKZOQc/IsI9sliJLFlpBY0d1rGGqzvN7JWqXi5sBF Gy7w+oy9XXGBaikC+s3DlaY4l4x4dWvIjO5Hqex+eq4yljotLVCxbYqGr64HJDQ4Oa7dV/ hNGNvlGcPOcEroSCfaIDP5dGTHEkVEx3U7wgVy0L79wu/gFILg+wHdIuBUUV6poWYZSgAk KO5TxuJeliF425mLwnRZVUKi6Bd1yerBEnZssztOjzMR3wz00wopTfD1gg6aww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=GIVhZ9C8; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 05D73FACE for ; Mon, 29 Apr 2024 18:52:04 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1UDo-0004Xf-5m; Mon, 29 Apr 2024 12:51:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1UDh-0004X0-38 for emacs-orgmode@gnu.org; Mon, 29 Apr 2024 12:51:13 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1UDe-0002MS-El for emacs-orgmode@gnu.org; Mon, 29 Apr 2024 12:51:12 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C268B240029 for ; Mon, 29 Apr 2024 18:51:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714409467; bh=C5usjRge3TGlWjGEARIi4IjzeZKWXuC7hzdp/F6nfg8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=GIVhZ9C85jTrO006/gGODx1MZuJPKtqk4mq1P8ANnpw64mM3ttvu8SBUVoNzX51cn 5wolxQdnKuNR+jYAZvxzOntwsIUjk6S0TvjE80v9co5nyvGqGuWjnYakQgMEhWFRHw DjsszA0SZTiKWW9/9rxJaBKwK3tzPVr3+PxlW+PiTeGgYxfr/F861+te6QoBeB/0JE +9da3tS2MO23LFbm1zpbFDPAOf3Of5ty0CkLgdijPD86hNNnx5xK40pTXJyEyvyQ9+ 4Zt5gSlTXrb73xlXZV5hWROT7iwGa3LlpMWSJG9Mhmb9CQpXowGp+0+peYeAShlUiq X+afC4h9JU1jA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VSq8p6jVrz6tx2; Mon, 29 Apr 2024 18:51:06 +0200 (CEST) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-make-tags-matcher: Compile returned function In-Reply-To: References: Date: Mon, 29 Apr 2024 16:52:12 +0000 Message-ID: <87wmogaz7n.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.60 X-Spam-Score: -6.60 X-Migadu-Queue-Id: 05D73FACE X-Migadu-Scanner: mx11.migadu.com X-TUID: UHBnQOHzekEw Morgan Smith writes: > This should result in a nice performance boost when the function is > called repeatedly (as is often done). > > * lisp/org.el (org-make-tags-matcher): Evaluate returned function to > compile it into a closure. > ... > I don't have any rigorous benchmarks but this does make things significantly > faster. This actually seems to have a bigger performance impact on > `org-clock-sum' then my rewrite of `org-clock-sum' I submitted earlier does. > Which is a little frustrating honestly. > > It does involve using the `eval' function which I know is a little taboo. > Although in this case I don't believe it actually adds any danger. I am able to reproduce a noticeable ~10% speedup. Even better approach is byte-compiling the result. It yields ~20% speedup. I applied an alternative patch that byte-compiles the returned function. Handled, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3e11b2eb8 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at