From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2NypN7GQPGbwNgEAe85BDQ:P1 (envelope-from ) for ; Thu, 09 May 2024 11:00:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2NypN7GQPGbwNgEAe85BDQ (envelope-from ) for ; Thu, 09 May 2024 11:00:34 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=VXhP6BSQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715245233; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=KsrF6AwCu/1DIAF8mlLvDMOu4oR8P+Am8CLsoYhLpzg=; b=SYuDPHkdfy7qswxXs4FUSbNv4uMcEz7nBZBiH2NfuYc9W5pbQAbfhE93nQQZ2H6gnIfVrA vxCU6fhbYxIxcS5eEDGXv8noCY1OTD+rx4ZviWeXjCeUVg6XBAMYvuonp6qEjqUNgyMGm+ dSsOiCUMHsm43LEszqDH+C6iwtuMI+9lSyDf8i+Hzg3yJ8SomFnrZGT8EaZsOTYelFyBJp 9sASuXZ3COLX/ZxLKNMjQ+l5gVkJoAc0KZyOIh419ZxhwByQxotOjCAPC0jf/ou0zDts/B JHd5nL5ikgIE41jVQfNygat6OR+tuCvEYB8X0IpB0DXULA2RBuRYF6vfG6leZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=VXhP6BSQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715245233; a=rsa-sha256; cv=none; b=teylV8GMZyv39LMfqiGfcRxwWlu77ezZ3MA7ZtzY3UbrBtoGsTMJcsa29JVGU3k5dy8Roc I7z6Pk2WzmGmkwY5Ot4+b4wJ7YEyR2Wi7lutUGUxBZkp/sn50iIGyjfWgAH7htshm/LJSJ TS76gZ1Id1E1J09W4DDWpU71PeLeLF4RscCw1nIRmggMAZHWRtfI8dCb3pgFQNzzrofOT4 AFjy5UpXPXrGDAGdrTzrwbkE4glZL3y79/j9NWvMEi5O9JeIcbFxtfHlFUXjyvEpdlFc+j PvwX2q2s81W0nFiro7M9C4uqevCFh4fE6St8wEOM5NkWTpFLdEOxQXG6huPi1g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A6908A293 for ; Thu, 9 May 2024 11:00:33 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4zck-0002Fv-N2; Thu, 09 May 2024 04:59:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4zcS-0002EL-1f for emacs-orgmode@gnu.org; Thu, 09 May 2024 04:59:16 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4zcP-0007i8-LH for emacs-orgmode@gnu.org; Thu, 09 May 2024 04:59:15 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5D32724002A for ; Thu, 9 May 2024 10:59:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715245142; bh=KsrF6AwCu/1DIAF8mlLvDMOu4oR8P+Am8CLsoYhLpzg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=VXhP6BSQ+kiNMiz2HjJnNySvBOj47GQBAguvcDmLERZwjIN1bSJpR+MEVkqKGt8ER 7y3uVIYFPD/6nDtxjgkrJ2dIH+Zs5YqFON0G49SQI+so8WeHU9borKML4nxaRS1Nos QK7XhpsiNiqlZ5AkqvW/395XtTL9ba85ixczIO+O5YxcF2uHoMYWBWtHFEod8aKfqZ xNMjQc7/RNRYrYa/qn5/NcGKZ9a2hPu9veawCc1pj3hFhFxbillHR/rAG7gGsb9Bh9 gZ9Qf+3V3v+BmWsz+9ZCGJoJJ8xSBZNJiYqe8bz/IDh21lHMngCZw+ao0N3seoZdFT zeLvNqp7qY/Uw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VZmCT17x1z6tmv; Thu, 9 May 2024 10:59:00 +0200 (CEST) From: Ihor Radchenko To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix a possibly problematic string comparison In-Reply-To: <20230827214320.46754-1-salutis@me.com> References: <20230827214320.46754-1-salutis@me.com> Date: Thu, 09 May 2024 09:00:30 +0000 Message-ID: <87wmo3qs0h.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -7.65 X-Migadu-Queue-Id: A6908A293 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.65 X-TUID: ncIA/bXGuxG0 Rudolf Adamkovi=C4=8D writes: > * lisp/org-table.el (org-table-make-reference): Replace 'eq' with > 'string-empty-p' to resolve "Warning: 'eq' called with literal string > that may never match" issued on every 'make' invocation. Handled, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3Dbd5665e01 I went with the non-breaking change. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at